Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 18749002: Use typedefs in lib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_collection_dev/iterable.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index 9032bf5771014cebc31741fd6f7bb9c10a93c6a6..a5d8ed2fb5ec2525e94e7cc5dec832d61afc58e7 100644
--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -1544,9 +1544,9 @@ class CodeEmitterTask extends CompilerTask {
bool canGenerateCheckedSetter(Element member) {
DartType type = member.computeType(compiler);
- if (type.element.isTypeVariable()
- || type.element == compiler.dynamicClass
- || type.element == compiler.objectClass) {
+ if (type.containsTypeVariables ||
Johnni Winther 2013/07/05 06:38:26 This is a temporary fix for issue 11273.
karlklose 2013/07/08 08:37:30 Change that to bailout for function types and go t
karlklose 2013/07/08 08:37:30 Change that to bailout for function types and go t
+ type.element == compiler.dynamicClass ||
+ type.element == compiler.objectClass) {
// TODO(ngeoffray): Support type checks on type parameters.
return false;
}
« no previous file with comments | « sdk/lib/_collection_dev/iterable.dart ('k') | sdk/lib/async/stream.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698