content/browser/notifications/notification_database.cc - Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_database.cc

Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database.h ('k') | content/browser/notifications/notification_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_database.cc

diff --git a/content/browser/notifications/notification_database.cc b/content/browser/notifications/notification_database.cc

index 4d9f42e0e50f91c84466b0bd303e7fc1e5de6def..3b4ba9fc5e3bdcced1bc1f27903b082fba453636 100644

--- a/content/browser/notifications/notification_database.cc

+++ b/content/browser/notifications/notification_database.cc

@@ -301,7 +301,8 @@ NotificationDatabase::ReadAllNotificationDataInternal(

leveldb::Slice prefix_slice(prefix);

NotificationDatabaseData notification_database_data;

- scoped_ptr<leveldb::Iterator> iter(db_->NewIterator(leveldb::ReadOptions()));

+ std::unique_ptr<leveldb::Iterator> iter(

+ db_->NewIterator(leveldb::ReadOptions()));

for (iter->Seek(prefix_slice); iter->Valid(); iter->Next()) {

if (!iter->key().starts_with(prefix_slice))

break;

@@ -338,7 +339,8 @@ NotificationDatabase::DeleteAllNotificationDataInternal(

leveldb::WriteBatch batch;