Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1359)

Unified Diff: content/browser/geolocation/network_location_provider_unittest.cc

Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/geolocation/network_location_provider_unittest.cc
diff --git a/content/browser/geolocation/network_location_provider_unittest.cc b/content/browser/geolocation/network_location_provider_unittest.cc
index 0b09a39fa8f23aba80ad8bbe35fb17d6105735d9..ebbf582160a89411c58af261473faa3617cb33bd 100644
--- a/content/browser/geolocation/network_location_provider_unittest.cc
+++ b/content/browser/geolocation/network_location_provider_unittest.cc
@@ -2,12 +2,15 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "content/browser/geolocation/network_location_provider.h"
+
#include <stddef.h>
+#include <memory>
+
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -15,7 +18,6 @@
#include "base/values.h"
#include "content/browser/geolocation/fake_access_token_store.h"
#include "content/browser/geolocation/location_arbitrator_impl.h"
-#include "content/browser/geolocation/network_location_provider.h"
#include "content/browser/geolocation/wifi_data_provider.h"
#include "net/base/net_errors.h"
#include "net/url_request/test_url_fetcher_factory.h"
@@ -262,8 +264,9 @@ class GeolocationNetworkProviderTest : public testing::Test {
const std::string& upload_data = request.upload_data();
ASSERT_FALSE(upload_data.empty());
std::string json_parse_error_msg;
- scoped_ptr<base::Value> parsed_json = base::JSONReader::ReadAndReturnError(
- upload_data, base::JSON_PARSE_RFC, NULL, &json_parse_error_msg);
+ std::unique_ptr<base::Value> parsed_json =
+ base::JSONReader::ReadAndReturnError(upload_data, base::JSON_PARSE_RFC,
+ NULL, &json_parse_error_msg);
EXPECT_TRUE(json_parse_error_msg.empty());
ASSERT_TRUE(parsed_json.get() != NULL);
@@ -320,14 +323,14 @@ class GeolocationNetworkProviderTest : public testing::Test {
TEST_F(GeolocationNetworkProviderTest, CreateDestroy) {
// Test fixture members were SetUp correctly.
EXPECT_EQ(&main_message_loop_, base::MessageLoop::current());
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(NULL != provider.get());
provider.reset();
SUCCEED();
}
TEST_F(GeolocationNetworkProviderTest, StartProvider) {
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
net::TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
ASSERT_TRUE(fetcher != NULL);
@@ -336,7 +339,7 @@ TEST_F(GeolocationNetworkProviderTest, StartProvider) {
TEST_F(GeolocationNetworkProviderTest, StartProviderDefaultUrl) {
test_server_url_ = LocationArbitratorImpl::DefaultNetworkProviderURL();
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
net::TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
ASSERT_TRUE(fetcher != NULL);
@@ -344,7 +347,7 @@ TEST_F(GeolocationNetworkProviderTest, StartProviderDefaultUrl) {
}
TEST_F(GeolocationNetworkProviderTest, StartProviderLongRequest) {
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
const int kFirstScanAps = 20;
wifi_data_provider_->SetData(CreateReferenceWifiScanData(kFirstScanAps));
@@ -359,7 +362,7 @@ TEST_F(GeolocationNetworkProviderTest, StartProviderLongRequest) {
}
TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
net::TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
@@ -463,7 +466,7 @@ TEST_F(GeolocationNetworkProviderTest, MultipleWifiScansComplete) {
TEST_F(GeolocationNetworkProviderTest, NoRequestOnStartupUntilWifiData) {
MessageLoopQuitListener listener;
wifi_data_provider_->set_got_data(false);
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
provider->SetUpdateCallback(base::Bind(
@@ -481,7 +484,7 @@ TEST_F(GeolocationNetworkProviderTest, NoRequestOnStartupUntilWifiData) {
TEST_F(GeolocationNetworkProviderTest, NewDataReplacesExistingNetworkRequest) {
// Send initial request with empty data
- scoped_ptr<LocationProvider> provider(CreateProvider(true));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(true));
EXPECT_TRUE(provider->StartProvider(false));
net::TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
EXPECT_TRUE(fetcher);
@@ -494,7 +497,7 @@ TEST_F(GeolocationNetworkProviderTest, NewDataReplacesExistingNetworkRequest) {
}
TEST_F(GeolocationNetworkProviderTest, NetworkRequestDeferredForPermission) {
- scoped_ptr<LocationProvider> provider(CreateProvider(false));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(false));
EXPECT_TRUE(provider->StartProvider(false));
net::TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
EXPECT_FALSE(fetcher);
@@ -510,7 +513,7 @@ TEST_F(GeolocationNetworkProviderTest,
NetworkRequestWithWifiDataDeferredForPermission) {
access_token_store_->access_token_map_[test_server_url_] =
base::UTF8ToUTF16(REFERENCE_ACCESS_TOKEN);
- scoped_ptr<LocationProvider> provider(CreateProvider(false));
+ std::unique_ptr<LocationProvider> provider(CreateProvider(false));
EXPECT_TRUE(provider->StartProvider(false));
net::TestURLFetcher* fetcher = get_url_fetcher_and_advance_id();
EXPECT_FALSE(fetcher);
« no previous file with comments | « content/browser/geolocation/network_location_provider.h ('k') | content/browser/geolocation/network_location_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698