content/browser/devtools/protocol/tracing_handler_unittest.cc - Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/protocol/tracing_handler_unittest.cc

Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/tracing_handler.cc ('k') | content/browser/devtools/render_frame_devtools_agent_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/protocol/tracing_handler_unittest.cc

diff --git a/content/browser/devtools/protocol/tracing_handler_unittest.cc b/content/browser/devtools/protocol/tracing_handler_unittest.cc

index 8182f45826f4600f40db47ab05945aa8b6f2998a..85b01d883abf237b4f23d7bd8851e8a5f2a33a05 100644

--- a/content/browser/devtools/protocol/tracing_handler_unittest.cc

+++ b/content/browser/devtools/protocol/tracing_handler_unittest.cc

@@ -57,9 +57,9 @@ const char kCustomTraceConfigStringDevToolsStyle[] =

}

TEST(TracingHandlerTest, GetTraceConfigFromDevToolsConfig) {

- scoped_ptr<base::Value> value = base::JSONReader::Read(

- kCustomTraceConfigStringDevToolsStyle);

- scoped_ptr<base::DictionaryValue> devtools_style_dict(

+ std::unique_ptr<base::Value> value =

+ base::JSONReader::Read(kCustomTraceConfigStringDevToolsStyle);

+ std::unique_ptr<base::DictionaryValue> devtools_style_dict(

static_cast<base::DictionaryValue*>(value.release()));

base::trace_event::TraceConfig trace_config =