Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: content/browser/appcache/appcache_request_handler_unittest.cc

Issue 1874893002: Convert //content/browser from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/appcache/appcache_request_handler.h" 5 #include "content/browser/appcache/appcache_request_handler.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8
8 #include <stack> 9 #include <stack>
9 #include <string> 10 #include <string>
10 #include <utility> 11 #include <utility>
11 #include <vector> 12 #include <vector>
12 13
13 #include "base/bind.h" 14 #include "base/bind.h"
14 #include "base/bind_helpers.h" 15 #include "base/bind_helpers.h"
15 #include "base/callback.h" 16 #include "base/callback.h"
16 #include "base/location.h" 17 #include "base/location.h"
17 #include "base/macros.h" 18 #include "base/macros.h"
19 #include "base/memory/ptr_util.h"
18 #include "base/memory/weak_ptr.h" 20 #include "base/memory/weak_ptr.h"
19 #include "base/single_thread_task_runner.h" 21 #include "base/single_thread_task_runner.h"
20 #include "base/synchronization/waitable_event.h" 22 #include "base/synchronization/waitable_event.h"
21 #include "base/thread_task_runner_handle.h" 23 #include "base/thread_task_runner_handle.h"
22 #include "base/threading/thread.h" 24 #include "base/threading/thread.h"
23 #include "content/browser/appcache/appcache.h" 25 #include "content/browser/appcache/appcache.h"
24 #include "content/browser/appcache/appcache_backend_impl.h" 26 #include "content/browser/appcache/appcache_backend_impl.h"
25 #include "content/browser/appcache/appcache_url_request_job.h" 27 #include "content/browser/appcache/appcache_url_request_job.h"
26 #include "content/browser/appcache/mock_appcache_policy.h" 28 #include "content/browser/appcache/mock_appcache_policy.h"
27 #include "content/browser/appcache/mock_appcache_service.h" 29 #include "content/browser/appcache/mock_appcache_service.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 bool has_response_info_; 115 bool has_response_info_;
114 net::HttpResponseInfo response_info_; 116 net::HttpResponseInfo response_info_;
115 }; 117 };
116 118
117 class MockURLRequestJobFactory : public net::URLRequestJobFactory { 119 class MockURLRequestJobFactory : public net::URLRequestJobFactory {
118 public: 120 public:
119 MockURLRequestJobFactory() {} 121 MockURLRequestJobFactory() {}
120 122
121 ~MockURLRequestJobFactory() override { DCHECK(!job_); } 123 ~MockURLRequestJobFactory() override { DCHECK(!job_); }
122 124
123 void SetJob(scoped_ptr<net::URLRequestJob> job) { job_ = std::move(job); } 125 void SetJob(std::unique_ptr<net::URLRequestJob> job) {
126 job_ = std::move(job);
127 }
124 128
125 net::URLRequestJob* MaybeCreateJobWithProtocolHandler( 129 net::URLRequestJob* MaybeCreateJobWithProtocolHandler(
126 const std::string& scheme, 130 const std::string& scheme,
127 net::URLRequest* request, 131 net::URLRequest* request,
128 net::NetworkDelegate* network_delegate) const override { 132 net::NetworkDelegate* network_delegate) const override {
129 if (job_) 133 if (job_)
130 return job_.release(); 134 return job_.release();
131 135
132 // Some of these tests trigger UpdateJobs which start URLRequests. 136 // Some of these tests trigger UpdateJobs which start URLRequests.
133 // We short circuit those be returning error jobs. 137 // We short circuit those be returning error jobs.
(...skipping 20 matching lines...) Expand all
154 158
155 bool IsHandledURL(const GURL& url) const override { 159 bool IsHandledURL(const GURL& url) const override {
156 return url.SchemeIs("http"); 160 return url.SchemeIs("http");
157 } 161 }
158 162
159 bool IsSafeRedirectTarget(const GURL& location) const override { 163 bool IsSafeRedirectTarget(const GURL& location) const override {
160 return false; 164 return false;
161 } 165 }
162 166
163 private: 167 private:
164 mutable scoped_ptr<net::URLRequestJob> job_; 168 mutable std::unique_ptr<net::URLRequestJob> job_;
165 }; 169 };
166 170
167 static void SetUpTestCase() { 171 static void SetUpTestCase() {
168 io_thread_.reset(new base::Thread("AppCacheRequestHandlerTest Thread")); 172 io_thread_.reset(new base::Thread("AppCacheRequestHandlerTest Thread"));
169 base::Thread::Options options(base::MessageLoop::TYPE_IO, 0); 173 base::Thread::Options options(base::MessageLoop::TYPE_IO, 0);
170 io_thread_->StartWithOptions(options); 174 io_thread_->StartWithOptions(options);
171 } 175 }
172 176
173 static void TearDownTestCase() { 177 static void TearDownTestCase() {
174 io_thread_.reset(NULL); 178 io_thread_.reset(NULL);
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 EXPECT_FALSE(job_->is_waiting()); 277 EXPECT_FALSE(job_->is_waiting());
274 EXPECT_TRUE(job_->is_delivering_network_response()); 278 EXPECT_TRUE(job_->is_delivering_network_response());
275 279
276 int64_t cache_id = kAppCacheNoCacheId; 280 int64_t cache_id = kAppCacheNoCacheId;
277 GURL manifest_url; 281 GURL manifest_url;
278 handler_->GetExtraResponseInfo(&cache_id, &manifest_url); 282 handler_->GetExtraResponseInfo(&cache_id, &manifest_url);
279 EXPECT_EQ(kAppCacheNoCacheId, cache_id); 283 EXPECT_EQ(kAppCacheNoCacheId, cache_id);
280 EXPECT_EQ(GURL(), manifest_url); 284 EXPECT_EQ(GURL(), manifest_url);
281 EXPECT_EQ(0, handler_->found_group_id_); 285 EXPECT_EQ(0, handler_->found_group_id_);
282 286
283 scoped_ptr<AppCacheURLRequestJob> fallback_job( 287 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
284 handler_->MaybeLoadFallbackForRedirect( 288 handler_->MaybeLoadFallbackForRedirect(
285 request_.get(), request_->context()->network_delegate(), 289 request_.get(), request_->context()->network_delegate(),
286 GURL("http://blah/redirect"))); 290 GURL("http://blah/redirect")));
287 EXPECT_FALSE(fallback_job); 291 EXPECT_FALSE(fallback_job);
288 fallback_job.reset(handler_->MaybeLoadFallbackForResponse( 292 fallback_job.reset(handler_->MaybeLoadFallbackForResponse(
289 request_.get(), request_->context()->network_delegate())); 293 request_.get(), request_->context()->network_delegate()));
290 EXPECT_FALSE(fallback_job); 294 EXPECT_FALSE(fallback_job);
291 295
292 EXPECT_TRUE(host_->preferred_manifest_url().is_empty()); 296 EXPECT_TRUE(host_->preferred_manifest_url().is_empty());
293 297
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 EXPECT_FALSE(job_->is_waiting()); 330 EXPECT_FALSE(job_->is_waiting());
327 EXPECT_TRUE(job_->is_delivering_appcache_response()); 331 EXPECT_TRUE(job_->is_delivering_appcache_response());
328 332
329 int64_t cache_id = kAppCacheNoCacheId; 333 int64_t cache_id = kAppCacheNoCacheId;
330 GURL manifest_url; 334 GURL manifest_url;
331 handler_->GetExtraResponseInfo(&cache_id, &manifest_url); 335 handler_->GetExtraResponseInfo(&cache_id, &manifest_url);
332 EXPECT_EQ(1, cache_id); 336 EXPECT_EQ(1, cache_id);
333 EXPECT_EQ(GURL("http://blah/manifest/"), manifest_url); 337 EXPECT_EQ(GURL("http://blah/manifest/"), manifest_url);
334 EXPECT_EQ(2, handler_->found_group_id_); 338 EXPECT_EQ(2, handler_->found_group_id_);
335 339
336 scoped_ptr<AppCacheURLRequestJob> fallback_job( 340 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
337 handler_->MaybeLoadFallbackForResponse( 341 handler_->MaybeLoadFallbackForResponse(
338 request_.get(), request_->context()->network_delegate())); 342 request_.get(), request_->context()->network_delegate()));
339 EXPECT_FALSE(fallback_job); 343 EXPECT_FALSE(fallback_job);
340 344
341 EXPECT_EQ(GURL("http://blah/manifest/"), 345 EXPECT_EQ(GURL("http://blah/manifest/"),
342 host_->preferred_manifest_url()); 346 host_->preferred_manifest_url());
343 347
344 TestFinished(); 348 TestFinished();
345 } 349 }
346 350
(...skipping 20 matching lines...) Expand all
367 job_.reset(handler_->MaybeLoadResource( 371 job_.reset(handler_->MaybeLoadResource(
368 request_.get(), request_->context()->network_delegate())); 372 request_.get(), request_->context()->network_delegate()));
369 EXPECT_TRUE(job_.get()); 373 EXPECT_TRUE(job_.get());
370 EXPECT_TRUE(job_->is_waiting()); 374 EXPECT_TRUE(job_->is_waiting());
371 375
372 // We have to wait for completion of storage->FindResponseForMainRequest. 376 // We have to wait for completion of storage->FindResponseForMainRequest.
373 ScheduleNextTask(); 377 ScheduleNextTask();
374 } 378 }
375 379
376 void SimulateResponseCode(int response_code) { 380 void SimulateResponseCode(int response_code) {
377 job_factory_->SetJob(make_scoped_ptr(new MockURLRequestJob( 381 job_factory_->SetJob(base::WrapUnique(new MockURLRequestJob(
378 request_.get(), request_->context()->network_delegate(), 382 request_.get(), request_->context()->network_delegate(),
379 response_code))); 383 response_code)));
380 request_->Start(); 384 request_->Start();
381 // All our simulation needs to satisfy are the following two DCHECKs 385 // All our simulation needs to satisfy are the following two DCHECKs
382 DCHECK(request_->status().is_success()); 386 DCHECK(request_->status().is_success());
383 DCHECK_EQ(response_code, request_->GetResponseCode()); 387 DCHECK_EQ(response_code, request_->GetResponseCode());
384 } 388 }
385 389
386 void SimulateResponseInfo(const net::HttpResponseInfo& info) { 390 void SimulateResponseInfo(const net::HttpResponseInfo& info) {
387 job_factory_->SetJob(make_scoped_ptr(new MockURLRequestJob( 391 job_factory_->SetJob(base::WrapUnique(new MockURLRequestJob(
388 request_.get(), request_->context()->network_delegate(), info))); 392 request_.get(), request_->context()->network_delegate(), info)));
389 request_->Start(); 393 request_->Start();
390 } 394 }
391 395
392 void Verify_MainResource_Fallback() { 396 void Verify_MainResource_Fallback() {
393 EXPECT_FALSE(job_->is_waiting()); 397 EXPECT_FALSE(job_->is_waiting());
394 EXPECT_TRUE(job_->is_delivering_network_response()); 398 EXPECT_TRUE(job_->is_delivering_network_response());
395 399
396 // The handler expects to the job to tell it that the request is going to 400 // The handler expects to the job to tell it that the request is going to
397 // be restarted before it sees the next request. 401 // be restarted before it sees the next request.
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 handler_.reset(host_->CreateRequestHandler(request_.get(), 528 handler_.reset(host_->CreateRequestHandler(request_.get(),
525 RESOURCE_TYPE_SUB_RESOURCE, 529 RESOURCE_TYPE_SUB_RESOURCE,
526 false)); 530 false));
527 EXPECT_TRUE(handler_.get()); 531 EXPECT_TRUE(handler_.get());
528 532
529 job_.reset(handler_->MaybeLoadResource( 533 job_.reset(handler_->MaybeLoadResource(
530 request_.get(), request_->context()->network_delegate())); 534 request_.get(), request_->context()->network_delegate()));
531 EXPECT_TRUE(job_.get()); 535 EXPECT_TRUE(job_.get());
532 EXPECT_TRUE(job_->is_delivering_error_response()); 536 EXPECT_TRUE(job_->is_delivering_error_response());
533 537
534 scoped_ptr<AppCacheURLRequestJob> fallback_job( 538 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
535 handler_->MaybeLoadFallbackForRedirect( 539 handler_->MaybeLoadFallbackForRedirect(
536 request_.get(), request_->context()->network_delegate(), 540 request_.get(), request_->context()->network_delegate(),
537 GURL("http://blah/redirect"))); 541 GURL("http://blah/redirect")));
538 EXPECT_FALSE(fallback_job); 542 EXPECT_FALSE(fallback_job);
539 fallback_job.reset(handler_->MaybeLoadFallbackForResponse( 543 fallback_job.reset(handler_->MaybeLoadFallbackForResponse(
540 request_.get(), request_->context()->network_delegate())); 544 request_.get(), request_->context()->network_delegate()));
541 EXPECT_FALSE(fallback_job); 545 EXPECT_FALSE(fallback_job);
542 546
543 TestFinished(); 547 TestFinished();
544 } 548 }
(...skipping 14 matching lines...) Expand all
559 EXPECT_TRUE(handler_.get()); 563 EXPECT_TRUE(handler_.get());
560 job_.reset(handler_->MaybeLoadResource( 564 job_.reset(handler_->MaybeLoadResource(
561 request_.get(), request_->context()->network_delegate())); 565 request_.get(), request_->context()->network_delegate()));
562 EXPECT_TRUE(job_.get()); 566 EXPECT_TRUE(job_.get());
563 EXPECT_TRUE(job_->is_waiting()); 567 EXPECT_TRUE(job_->is_waiting());
564 568
565 host_->FinishCacheSelection(cache.get(), NULL); 569 host_->FinishCacheSelection(cache.get(), NULL);
566 EXPECT_FALSE(job_->is_waiting()); 570 EXPECT_FALSE(job_->is_waiting());
567 EXPECT_TRUE(job_->is_delivering_error_response()); 571 EXPECT_TRUE(job_->is_delivering_error_response());
568 572
569 scoped_ptr<AppCacheURLRequestJob> fallback_job( 573 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
570 handler_->MaybeLoadFallbackForRedirect( 574 handler_->MaybeLoadFallbackForRedirect(
571 request_.get(), request_->context()->network_delegate(), 575 request_.get(), request_->context()->network_delegate(),
572 GURL("http://blah/redirect"))); 576 GURL("http://blah/redirect")));
573 EXPECT_FALSE(fallback_job); 577 EXPECT_FALSE(fallback_job);
574 fallback_job.reset(handler_->MaybeLoadFallbackForResponse( 578 fallback_job.reset(handler_->MaybeLoadFallbackForResponse(
575 request_.get(), request_->context()->network_delegate())); 579 request_.get(), request_->context()->network_delegate()));
576 EXPECT_FALSE(fallback_job); 580 EXPECT_FALSE(fallback_job);
577 581
578 TestFinished(); 582 TestFinished();
579 } 583 }
(...skipping 10 matching lines...) Expand all
590 GURL("http://blah/"), net::DEFAULT_PRIORITY, &delegate_); 594 GURL("http://blah/"), net::DEFAULT_PRIORITY, &delegate_);
591 handler_.reset(host_->CreateRequestHandler(request_.get(), 595 handler_.reset(host_->CreateRequestHandler(request_.get(),
592 RESOURCE_TYPE_SUB_RESOURCE, 596 RESOURCE_TYPE_SUB_RESOURCE,
593 false)); 597 false));
594 EXPECT_TRUE(handler_.get()); 598 EXPECT_TRUE(handler_.get());
595 job_.reset(handler_->MaybeLoadResource( 599 job_.reset(handler_->MaybeLoadResource(
596 request_.get(), request_->context()->network_delegate())); 600 request_.get(), request_->context()->network_delegate()));
597 EXPECT_TRUE(job_.get()); 601 EXPECT_TRUE(job_.get());
598 EXPECT_TRUE(job_->is_delivering_appcache_response()); 602 EXPECT_TRUE(job_->is_delivering_appcache_response());
599 603
600 scoped_ptr<AppCacheURLRequestJob> fallback_job( 604 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
601 handler_->MaybeLoadFallbackForRedirect( 605 handler_->MaybeLoadFallbackForRedirect(
602 request_.get(), request_->context()->network_delegate(), 606 request_.get(), request_->context()->network_delegate(),
603 GURL("http://blah/redirect"))); 607 GURL("http://blah/redirect")));
604 EXPECT_FALSE(fallback_job); 608 EXPECT_FALSE(fallback_job);
605 fallback_job.reset(handler_->MaybeLoadFallbackForResponse( 609 fallback_job.reset(handler_->MaybeLoadFallbackForResponse(
606 request_.get(), request_->context()->network_delegate())); 610 request_.get(), request_->context()->network_delegate()));
607 EXPECT_FALSE(fallback_job); 611 EXPECT_FALSE(fallback_job);
608 612
609 TestFinished(); 613 TestFinished();
610 } 614 }
(...skipping 17 matching lines...) Expand all
628 job_.reset(handler_->MaybeLoadResource( 632 job_.reset(handler_->MaybeLoadResource(
629 request_.get(), request_->context()->network_delegate())); 633 request_.get(), request_->context()->network_delegate()));
630 EXPECT_FALSE(job_.get()); 634 EXPECT_FALSE(job_.get());
631 635
632 job_.reset(handler_->MaybeLoadFallbackForRedirect( 636 job_.reset(handler_->MaybeLoadFallbackForRedirect(
633 request_.get(), request_->context()->network_delegate(), 637 request_.get(), request_->context()->network_delegate(),
634 GURL("http://not_blah/redirect"))); 638 GURL("http://not_blah/redirect")));
635 EXPECT_TRUE(job_.get()); 639 EXPECT_TRUE(job_.get());
636 EXPECT_TRUE(job_->is_delivering_appcache_response()); 640 EXPECT_TRUE(job_->is_delivering_appcache_response());
637 641
638 scoped_ptr<AppCacheURLRequestJob> fallback_job( 642 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
639 handler_->MaybeLoadFallbackForResponse( 643 handler_->MaybeLoadFallbackForResponse(
640 request_.get(), request_->context()->network_delegate())); 644 request_.get(), request_->context()->network_delegate()));
641 EXPECT_FALSE(fallback_job); 645 EXPECT_FALSE(fallback_job);
642 646
643 TestFinished(); 647 TestFinished();
644 } 648 }
645 649
646 // SubResource_NoRedirectFallback ----------------------------- 650 // SubResource_NoRedirectFallback -----------------------------
647 651
648 void SubResource_NoRedirectFallback() { 652 void SubResource_NoRedirectFallback() {
649 // Redirects to resources in the same-origin are not subject to 653 // Redirects to resources in the same-origin are not subject to
650 // fallback namespaces. 654 // fallback namespaces.
651 host_->AssociateCompleteCache(MakeNewCache()); 655 host_->AssociateCompleteCache(MakeNewCache());
652 656
653 mock_storage()->SimulateFindSubResource( 657 mock_storage()->SimulateFindSubResource(
654 AppCacheEntry(), AppCacheEntry(AppCacheEntry::EXPLICIT, 1), false); 658 AppCacheEntry(), AppCacheEntry(AppCacheEntry::EXPLICIT, 1), false);
655 659
656 request_ = empty_context_.CreateRequest( 660 request_ = empty_context_.CreateRequest(
657 GURL("http://blah/"), net::DEFAULT_PRIORITY, &delegate_); 661 GURL("http://blah/"), net::DEFAULT_PRIORITY, &delegate_);
658 handler_.reset(host_->CreateRequestHandler(request_.get(), 662 handler_.reset(host_->CreateRequestHandler(request_.get(),
659 RESOURCE_TYPE_SUB_RESOURCE, 663 RESOURCE_TYPE_SUB_RESOURCE,
660 false)); 664 false));
661 EXPECT_TRUE(handler_.get()); 665 EXPECT_TRUE(handler_.get());
662 job_.reset(handler_->MaybeLoadResource( 666 job_.reset(handler_->MaybeLoadResource(
663 request_.get(), request_->context()->network_delegate())); 667 request_.get(), request_->context()->network_delegate()));
664 EXPECT_FALSE(job_.get()); 668 EXPECT_FALSE(job_.get());
665 669
666 scoped_ptr<AppCacheURLRequestJob> fallback_job( 670 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
667 handler_->MaybeLoadFallbackForRedirect( 671 handler_->MaybeLoadFallbackForRedirect(
668 request_.get(), request_->context()->network_delegate(), 672 request_.get(), request_->context()->network_delegate(),
669 GURL("http://blah/redirect"))); 673 GURL("http://blah/redirect")));
670 EXPECT_FALSE(fallback_job); 674 EXPECT_FALSE(fallback_job);
671 675
672 SimulateResponseCode(200); 676 SimulateResponseCode(200);
673 fallback_job.reset(handler_->MaybeLoadFallbackForResponse( 677 fallback_job.reset(handler_->MaybeLoadFallbackForResponse(
674 request_.get(), request_->context()->network_delegate())); 678 request_.get(), request_->context()->network_delegate()));
675 EXPECT_FALSE(fallback_job); 679 EXPECT_FALSE(fallback_job);
676 680
(...skipping 14 matching lines...) Expand all
691 request_ = empty_context_.CreateRequest( 695 request_ = empty_context_.CreateRequest(
692 GURL("http://blah/"), net::DEFAULT_PRIORITY, &delegate_); 696 GURL("http://blah/"), net::DEFAULT_PRIORITY, &delegate_);
693 handler_.reset(host_->CreateRequestHandler(request_.get(), 697 handler_.reset(host_->CreateRequestHandler(request_.get(),
694 RESOURCE_TYPE_SUB_RESOURCE, 698 RESOURCE_TYPE_SUB_RESOURCE,
695 false)); 699 false));
696 EXPECT_TRUE(handler_.get()); 700 EXPECT_TRUE(handler_.get());
697 job_.reset(handler_->MaybeLoadResource( 701 job_.reset(handler_->MaybeLoadResource(
698 request_.get(), request_->context()->network_delegate())); 702 request_.get(), request_->context()->network_delegate()));
699 EXPECT_FALSE(job_.get()); 703 EXPECT_FALSE(job_.get());
700 704
701 scoped_ptr<AppCacheURLRequestJob> fallback_job( 705 std::unique_ptr<AppCacheURLRequestJob> fallback_job(
702 handler_->MaybeLoadFallbackForRedirect( 706 handler_->MaybeLoadFallbackForRedirect(
703 request_.get(), request_->context()->network_delegate(), 707 request_.get(), request_->context()->network_delegate(),
704 GURL("http://blah/redirect"))); 708 GURL("http://blah/redirect")));
705 EXPECT_FALSE(fallback_job); 709 EXPECT_FALSE(fallback_job);
706 fallback_job.reset(handler_->MaybeLoadFallbackForResponse( 710 fallback_job.reset(handler_->MaybeLoadFallbackForResponse(
707 request_.get(), request_->context()->network_delegate())); 711 request_.get(), request_->context()->network_delegate()));
708 EXPECT_FALSE(fallback_job); 712 EXPECT_FALSE(fallback_job);
709 713
710 TestFinished(); 714 TestFinished();
711 } 715 }
(...skipping 217 matching lines...) Expand 10 before | Expand all | Expand 10 after
929 group->AddCache(cache); 933 group->AddCache(cache);
930 return cache; 934 return cache;
931 } 935 }
932 936
933 MockAppCacheStorage* mock_storage() { 937 MockAppCacheStorage* mock_storage() {
934 return reinterpret_cast<MockAppCacheStorage*>(mock_service_->storage()); 938 return reinterpret_cast<MockAppCacheStorage*>(mock_service_->storage());
935 } 939 }
936 940
937 // Data members -------------------------------------------------- 941 // Data members --------------------------------------------------
938 942
939 scoped_ptr<base::WaitableEvent> test_finished_event_; 943 std::unique_ptr<base::WaitableEvent> test_finished_event_;
940 std::stack<base::Closure> task_stack_; 944 std::stack<base::Closure> task_stack_;
941 scoped_ptr<MockAppCacheService> mock_service_; 945 std::unique_ptr<MockAppCacheService> mock_service_;
942 scoped_ptr<AppCacheBackendImpl> backend_impl_; 946 std::unique_ptr<AppCacheBackendImpl> backend_impl_;
943 scoped_ptr<MockFrontend> mock_frontend_; 947 std::unique_ptr<MockFrontend> mock_frontend_;
944 scoped_ptr<MockAppCachePolicy> mock_policy_; 948 std::unique_ptr<MockAppCachePolicy> mock_policy_;
945 AppCacheHost* host_; 949 AppCacheHost* host_;
946 net::URLRequestContext empty_context_; 950 net::URLRequestContext empty_context_;
947 scoped_ptr<MockURLRequestJobFactory> job_factory_; 951 std::unique_ptr<MockURLRequestJobFactory> job_factory_;
948 MockURLRequestDelegate delegate_; 952 MockURLRequestDelegate delegate_;
949 scoped_ptr<net::URLRequest> request_; 953 std::unique_ptr<net::URLRequest> request_;
950 scoped_ptr<AppCacheRequestHandler> handler_; 954 std::unique_ptr<AppCacheRequestHandler> handler_;
951 scoped_ptr<AppCacheURLRequestJob> job_; 955 std::unique_ptr<AppCacheURLRequestJob> job_;
952 956
953 static scoped_ptr<base::Thread> io_thread_; 957 static std::unique_ptr<base::Thread> io_thread_;
954 }; 958 };
955 959
956 // static 960 // static
957 scoped_ptr<base::Thread> AppCacheRequestHandlerTest::io_thread_; 961 std::unique_ptr<base::Thread> AppCacheRequestHandlerTest::io_thread_;
958 962
959 TEST_F(AppCacheRequestHandlerTest, MainResource_Miss) { 963 TEST_F(AppCacheRequestHandlerTest, MainResource_Miss) {
960 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Miss); 964 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Miss);
961 } 965 }
962 966
963 TEST_F(AppCacheRequestHandlerTest, MainResource_Hit) { 967 TEST_F(AppCacheRequestHandlerTest, MainResource_Hit) {
964 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Hit); 968 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Hit);
965 } 969 }
966 970
967 TEST_F(AppCacheRequestHandlerTest, MainResource_Fallback) { 971 TEST_F(AppCacheRequestHandlerTest, MainResource_Fallback) {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
1024 1028
1025 TEST_F(AppCacheRequestHandlerTest, WorkerRequest) { 1029 TEST_F(AppCacheRequestHandlerTest, WorkerRequest) {
1026 RunTestOnIOThread(&AppCacheRequestHandlerTest::WorkerRequest); 1030 RunTestOnIOThread(&AppCacheRequestHandlerTest::WorkerRequest);
1027 } 1031 }
1028 1032
1029 TEST_F(AppCacheRequestHandlerTest, MainResource_Blocked) { 1033 TEST_F(AppCacheRequestHandlerTest, MainResource_Blocked) {
1030 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Blocked); 1034 RunTestOnIOThread(&AppCacheRequestHandlerTest::MainResource_Blocked);
1031 } 1035 }
1032 1036
1033 } // namespace content 1037 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/appcache/appcache_request_handler.cc ('k') | content/browser/appcache/appcache_response.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698