Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1874853002: VM: Remove unnecessary _Num class from runtime/lib. (Closed)

Created:
4 years, 8 months ago by Florian Schneider
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Remove unnecessary _Num class from runtime/lib. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/be298b60e961adf37806e4ac0fe19e1b1165fc42

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -34 lines) Patch
M runtime/lib/core_sources.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/double.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/lib/double.dart View 1 3 chunks +4 lines, -2 lines 0 comments Download
M runtime/lib/integers.dart View 1 chunk +1 line, -1 line 0 comments Download
D runtime/lib/num.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
D runtime/lib/num.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 8 months ago (2016-04-08 23:08:59 UTC) #2
rmacnak
LGTM! https://codereview.chromium.org/1874853002/diff/1/runtime/lib/double.dart File runtime/lib/double.dart (right): https://codereview.chromium.org/1874853002/diff/1/runtime/lib/double.dart#newcode143 runtime/lib/double.dart:143: String _toString() native "Num_toString"; Rename the native to ...
4 years, 8 months ago (2016-04-08 23:11:03 UTC) #3
Florian Schneider
https://codereview.chromium.org/1874853002/diff/1/runtime/lib/double.dart File runtime/lib/double.dart (right): https://codereview.chromium.org/1874853002/diff/1/runtime/lib/double.dart#newcode143 runtime/lib/double.dart:143: String _toString() native "Num_toString"; On 2016/04/08 23:11:03, rmacnak wrote: ...
4 years, 8 months ago (2016-04-08 23:19:17 UTC) #4
Florian Schneider
4 years, 8 months ago (2016-04-08 23:25:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
be298b60e961adf37806e4ac0fe19e1b1165fc42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698