Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187483005: Extending the Views-on-Mac experiment: whole app list grid.

Created:
6 years, 9 months ago by tapted
Modified:
6 years, 8 months ago
Reviewers:
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, dcheng, nona+watch_chromium.org, James Su
Visibility:
Public.

Description

Extending the Views-on-Mac experiment: whole app list grid. Based off https://codereview.chromium.org/195793005/ BUG=312961

Patch Set 1 #

Patch Set 2 : better upstream, Add mouse event handling #

Patch Set 3 : rebase at r256101 #

Patch Set 4 : rebase off crrev/195793005 #

Patch Set 5 : rebase and fix compile #

Patch Set 6 : rebase1 #

Patch Set 7 : still compiles r263560 + crrev/195793005 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1656 lines, -1925 lines) Patch
M chrome/browser/ui/app_list/app_list_controller_browsertest.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M skia/ext/skia_utils_mac.mm View 1 3 chunks +4 lines, -3 lines 0 comments Download
M ui/app_list/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 6 chunks +45 lines, -16 lines 0 comments Download
M ui/app_list/app_list_switches.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
D ui/app_list/cocoa/apps_collection_view_drag_manager.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
D ui/app_list/cocoa/apps_collection_view_drag_manager.mm View 1 1 chunk +0 lines, -263 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.h View 3 chunks +8 lines, -31 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.mm View 1 2 3 4 4 chunks +54 lines, -573 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_view_item.h View 1 1 chunk +0 lines, -64 lines 0 comments Download
D ui/app_list/cocoa/apps_grid_view_item.mm View 1 1 chunk +0 lines, -499 lines 0 comments Download
D ui/app_list/cocoa/item_drag_controller.h View 1 1 chunk +0 lines, -44 lines 0 comments Download
D ui/app_list/cocoa/item_drag_controller.mm View 1 1 chunk +0 lines, -184 lines 0 comments Download
D ui/app_list/cocoa/scroll_view_with_no_scrollbars.h View 1 1 chunk +0 lines, -30 lines 0 comments Download
D ui/app_list/cocoa/scroll_view_with_no_scrollbars.mm View 1 1 chunk +0 lines, -99 lines 0 comments Download
M ui/app_list/views/app_list_folder_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_item_view.cc View 1 2 3 4 5 5 chunks +6 lines, -5 lines 0 comments Download
M ui/app_list/views/apps_grid_view.h View 1 2 3 4 5 4 chunks +6 lines, -2 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 1 2 3 4 5 6 chunks +15 lines, -2 lines 0 comments Download
M ui/app_list/views/contents_switcher_view.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/folder_background_view.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/views/progress_bar_view.h View 1 2 chunks +2 lines, -1 line 0 comments Download
A ui/app_list/views/progress_bar_view_unittest_mac.mm View 1 1 chunk +53 lines, -0 lines 0 comments Download
M ui/app_list/views/search_result_list_view_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/views/top_icon_animation_view.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
A ui/base/dragdrop/drag_utils_mac.mm View 1 chunk +27 lines, -0 lines 0 comments Download
A ui/base/dragdrop/os_exchange_data_provider_mac.mm View 1 chunk +42 lines, -0 lines 0 comments Download
M ui/base/models/menu_separator_types.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M ui/base/ui_base.gyp View 1 2 3 4 5 5 chunks +10 lines, -3 lines 0 comments Download
M ui/events/test/cocoa_test_event_utils.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
A ui/gfx/cursor.h View 1 chunk +18 lines, -0 lines 0 comments Download
A ui/gfx/cursor_mac.mm View 1 chunk +19 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M ui/gfx/native_widget_types.h View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_mac.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 2 chunks +15 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_runner.h View 1 4 chunks +22 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_runner.cc View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
A ui/views/controls/native/native_view_host_mac.mm View 1 chunk +18 lines, -0 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 4 5 4 chunks +8 lines, -3 lines 0 comments Download
M ui/views/drag_utils.cc View 1 2 3 4 2 chunks +2 lines, -0 lines 0 comments Download
A ui/views/metrics_mac.mm View 1 chunk +25 lines, -0 lines 0 comments Download
M ui/views/view.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 3 4 5 3 chunks +5 lines, -1 line 0 comments Download
A + ui/views/view_mac.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
A ui/views/widget/native_widget_mac.h View 1 1 chunk +115 lines, -0 lines 0 comments Download
A ui/views/widget/native_widget_mac.mm View 1 1 chunk +265 lines, -0 lines 0 comments Download
M ui/views/widget/widget.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/window/custom_frame_view.cc View 1 2 3 4 4 chunks +10 lines, -7 lines 0 comments Download
A + ui/views_core/DEPS View 1 1 chunk +0 lines, -6 lines 0 comments Download
A ui/views_core/accessibility/native_view_accessibility_mac.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A ui/views_core/accessibility/native_view_accessibility_mac.mm View 1 1 chunk +24 lines, -0 lines 0 comments Download
A ui/views_core/bridged_view_impl_mac.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
A ui/views_core/bridged_view_impl_mac.mm View 1 1 chunk +242 lines, -0 lines 0 comments Download
A ui/views_core/bridged_view_mac.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A ui/views_core/bridged_view_mac.mm View 1 1 chunk +43 lines, -0 lines 0 comments Download
A ui/views_core/menu_runner_mac.mm View 1 2 3 1 chunk +142 lines, -0 lines 0 comments Download
A ui/views_core/views_core.gyp View 1 2 3 4 5 6 1 chunk +160 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698