Templatize CFX_{Byte,Wide}StringC

Templatize CFX_{Byte,Wide}StringC

Committed: https://pdfium.googlesource.com/pdfium/+/f7036ba5884b9829fcb17aea4f3a16831abb7516

[Tom Sepez, 2016-05-12 21:30:23]

Description was changed from

==========
Test whether std::make_unsigned<> compiles on the bots
==========

to

==========
Templatize CFX_ByteStringC

Precursor to implementing WideStringC using the same 
mechanism
==========

[Tom Sepez, 2016-05-12 23:23:46]

Description was changed from

==========
Templatize CFX_ByteStringC

Precursor to implementing WideStringC using the same 
mechanism
==========

to

==========
Templatize CFX_{Byte,Wide}StringC
==========

[Tom Sepez, 2016-05-13 17:15:46]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-05-13 17:15:47]

Lei, for review.

[Lei Zhang, 2016-05-13 20:47:41]

lgtm

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/cfx_string_...
File core/fxcrt/cfx_string_c_template.h (right):

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/cfx_string_...
core/fxcrt/cfx_string_c_template.h:21: using CharType = T;
Can you just use:

template <typename CharType>

on line 18?

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/include/fx_...
File core/fxcrt/include/fx_string.h (right):

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/include/fx_...
core/fxcrt/include/fx_string.h:12: #include <type_traits>
Not needed here?

[Tom Sepez, 2016-05-13 21:20:16]

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/cfx_string_...
File core/fxcrt/cfx_string_c_template.h (right):

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/cfx_string_...
core/fxcrt/cfx_string_c_template.h:21: using CharType = T;
On 2016/05/13 20:47:40, Lei Zhang wrote:
> Can you just use:
> 
> template <typename CharType>
> 
> on line 18?

No, there are places where we want to have CFX_ByteString::CharType visible
(testing/fx_string_testhelpers.cpp:20:35: error: no type named 'CharType' in
'CFX_StringCTemplate<FX_CHAR>).

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/include/fx_...
File core/fxcrt/include/fx_string.h (right):

https://codereview.chromium.org/1874773002/diff/300001/core/fxcrt/include/fx_...
core/fxcrt/include/fx_string.h:12: #include <type_traits>
On 2016/05/13 20:47:40, Lei Zhang wrote:
> Not needed here?

Done.

[Tom Sepez, 2016-05-13 21:21:04]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-05-13 21:21:06]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1874773002/#ps320001
(title: "Remove one <type_traits> include.")

[commit-bot: I haz the power, 2016-05-13 21:25:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874773002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874773002/320001

[commit-bot: I haz the power, 2016-05-13 22:02:47]

Description was changed from

==========
Templatize CFX_{Byte,Wide}StringC
==========

to

==========
Templatize CFX_{Byte,Wide}StringC

Committed:
https://pdfium.googlesource.com/pdfium/+/f7036ba5884b9829fcb17aea4f3a16831abb...
==========

[commit-bot: I haz the power, 2016-05-13 22:02:50]

Committed patchset #17 (id:320001) as
https://pdfium.googlesource.com/pdfium/+/f7036ba5884b9829fcb17aea4f3a16831abb...