Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1874763002:
Force upload to VRAM in filterImage (Closed)
|
Created:
4 years, 8 months ago by robertphillips Modified:
4 years, 8 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionForce upload to VRAM in filterImage
This forces the conversion of image filter result to VRAM (if it is required) prior to the filtered result being put into the ImageFilter cache.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1874763002
Committed: https://skia.googlesource.com/skia/+/29feef80de0af74eb24b703d6675aea1bc17e655
Patch Set 1 #Patch Set 2 : Fix bug #Patch Set 3 : update to ToT #Messages
Total messages: 19 (11 generated)
Description was changed from ========== Force upload to VRAM in filterImage ========== to ========== Force upload to VRAM in filterImage GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Force upload to VRAM in filterImage GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Force upload to VRAM in filterImage GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + senorblanco@chromium.org, senorblanco@google.com
Description was changed from ========== Force upload to VRAM in filterImage GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Force upload to VRAM in filterImage This forces the conversion of image filter result to VRAM (if it is required) prior to the filtered result being put into the ImageFilter cache. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874763002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874763002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from senorblanco@chromium.org Link to the patchset: https://codereview.chromium.org/1874763002/#ps40001 (title: "update to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874763002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874763002/40001
Message was sent while issue was closed.
Description was changed from ========== Force upload to VRAM in filterImage This forces the conversion of image filter result to VRAM (if it is required) prior to the filtered result being put into the ImageFilter cache. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Force upload to VRAM in filterImage This forces the conversion of image filter result to VRAM (if it is required) prior to the filtered result being put into the ImageFilter cache. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/29feef80de0af74eb24b703d6675aea1bc17e655 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/29feef80de0af74eb24b703d6675aea1bc17e655 |
