Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: content/renderer/browser_plugin/browser_plugin_browsertest.cc

Issue 187473004: Invoke LeakSanitizer on teardown of some browser test fixtures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/chrome_render_view_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin_browsertest.cc
diff --git a/content/renderer/browser_plugin/browser_plugin_browsertest.cc b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
index 0d2ed7387ad6c2c4884db5fbf5f6558ab9ed4b28..528b7d8ac070dec051042f1704dd7264fe855174 100644
--- a/content/renderer/browser_plugin/browser_plugin_browsertest.cc
+++ b/content/renderer/browser_plugin/browser_plugin_browsertest.cc
@@ -4,6 +4,7 @@
#include "content/renderer/browser_plugin/browser_plugin_browsertest.h"
+#include "base/debug/leak_annotations.h"
#include "base/files/file_path.h"
#include "base/memory/singleton.h"
#include "base/path_service.h"
@@ -107,6 +108,11 @@ void BrowserPluginTest::SetUp() {
void BrowserPluginTest::TearDown() {
BrowserPluginManager::set_factory_for_testing(
TestBrowserPluginManagerFactory::GetInstance());
+#if defined(LEAK_SANITIZER)
+ // Do this before shutting down V8 in RenderViewTest::TearDown().
+ // http://crbug.com/328552
+ __lsan_do_leak_check();
+#endif
content::RenderViewTest::TearDown();
test_content_renderer_client_.reset();
}
« no previous file with comments | « chrome/test/base/chrome_render_view_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698