Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: chrome/test/base/chrome_render_view_test.cc

Issue 187473004: Invoke LeakSanitizer on teardown of some browser test fixtures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/chrome_render_view_test.cc
diff --git a/chrome/test/base/chrome_render_view_test.cc b/chrome/test/base/chrome_render_view_test.cc
index e92236fff3787c14f1371673d0d543f44c4cada6..0d9fb77c08e890b424548328dd49fc4731bfbebb 100644
--- a/chrome/test/base/chrome_render_view_test.cc
+++ b/chrome/test/base/chrome_render_view_test.cc
@@ -4,6 +4,7 @@
#include "chrome/test/base/chrome_render_view_test.h"
+#include "base/debug/leak_annotations.h"
#include "chrome/browser/extensions/extension_function_dispatcher.h"
#include "chrome/common/render_messages.h"
#include "chrome/renderer/extensions/chrome_v8_context_set.h"
@@ -75,5 +76,10 @@ void ChromeRenderViewTest::TearDown() {
extension_dispatcher_->OnRenderProcessShutdown();
extension_dispatcher_ = NULL;
+#if defined(LEAK_SANITIZER)
+ // Do this before shutting down V8 in RenderViewTest::TearDown().
+ // http://crbug.com/328552
+ __lsan_do_leak_check();
+#endif
content::RenderViewTest::TearDown();
}
« no previous file with comments | « no previous file | content/renderer/browser_plugin/browser_plugin_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698