Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 187473003: Revert of Oilpan: Use weak pointers in StyleSheetContents caches. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis, oilpan-reviews
Visibility:
Public.

Description

Revert of Oilpan: Use weak pointers in StyleSheetContents caches. (https://codereview.chromium.org/185403016/) Reason for revert: This patch seems to have made a number of layout tests fail on the oilpan bots. Reverting while I investigate. Original issue's description: > Oilpan: Use weak pointers in StyleSheetContents caches. > > This fixes use-after-free that could occur when StyleSheetContents > dies when an allocation happens during insertion of a new > StyleSheetContents. Using the built-in weak processing this will > not happen because the iterator used during insertion will keep > the StyleSheetContents alive. > > R=erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168444 TBR=erik.corry@gmail.com,haraken@chromium.org,vegorov@chromium.org,zerny@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168458

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -21 lines) Patch
M Source/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.cpp View 3 chunks +10 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mads Ager (chromium)
Created Revert of Oilpan: Use weak pointers in StyleSheetContents caches.
6 years, 9 months ago (2014-03-05 09:37:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/187473003/1
6 years, 9 months ago (2014-03-05 09:37:48 UTC) #2
commit-bot: I haz the power
Change committed as 168458
6 years, 9 months ago (2014-03-05 09:38:37 UTC) #3
haraken
lgtm
6 years, 9 months ago (2014-03-05 09:38:55 UTC) #4
Erik Corry
lgtm
6 years, 9 months ago (2014-03-05 09:38:57 UTC) #5
haraken
6 years, 9 months ago (2014-03-05 09:38:57 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698