Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 1874653003: Skip running GYP if GYP_CHROMIUM_NO_ACTION is set in environment (Closed)

Created:
4 years, 8 months ago by kjellander_chromium
Modified:
4 years, 8 months ago
Reviewers:
fbarchard, fbarchard1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Skip running GYP if GYP_CHROMIUM_NO_ACTION is set in environment This is how GYP is skipped on the GN bots. If GYP runs, it will currently produce files in out/{Debug,Releaese} that makes GN fail. BUG=601140 TBR=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/870d9b513bf7bb2c8c29d907657e1a826291c49a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gyp_libyuv View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_chromium
Example failure: https://uberchromegw.corp.google.com/i/tryserver.libyuv/builders/android_gn/builds/3 Notice that GYP_CHROMIUM_NO_ACTION is set in the environment for the gclient runhooks ...
4 years, 8 months ago (2016-04-08 12:01:10 UTC) #1
kjellander_chromium
Committed patchset #1 (id:1) manually as 870d9b513bf7bb2c8c29d907657e1a826291c49a (presubmit successful).
4 years, 8 months ago (2016-04-08 12:01:46 UTC) #3
fbarchard1
rubberstamp lgtm
4 years, 8 months ago (2016-04-08 18:12:36 UTC) #5
fbarchard1
4 years, 8 months ago (2016-04-08 18:12:52 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698