Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 1874653002: Remove timeout multiplier for dart2js browser tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 7b1e5f6208c95fddc532553f004f0904cba31cf8..147cd993445f5759207f32ad6fd3056807b2e243 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -52,8 +52,6 @@ abstract class CompilerConfiguration {
bool useSdk = configuration['use_sdk'];
bool isCsp = configuration['csp'];
bool useCps = configuration['cps_ir'];
- // TODO(26060): Remove the browser multiplier when issue resolved.
- bool isBrowser = configuration['browser'];
switch (compiler) {
case 'dart2analyzer':
@@ -70,7 +68,6 @@ abstract class CompilerConfiguration {
useCps: useCps,
useSdk: useSdk,
isCsp: isCsp,
- isBrowser: isBrowser,
extraDart2jsOptions:
TestUtils.getExtraOptions(configuration, 'dart2js_options'));
case 'dart2app':
@@ -241,7 +238,6 @@ class Dart2xCompilerConfiguration extends CompilerConfiguration {
class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
final bool isCsp;
final bool useCps;
- final bool isBrowser;
final List<String> extraDart2jsOptions;
// We cache the extended environment to save memory.
static Map<String, String> cpsFlagCache;
@@ -254,7 +250,6 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
bool useSdk,
bool this.useCps,
bool this.isCsp,
- bool this.isBrowser,
this.extraDart2jsOptions})
: super('dart2js',
isDebug: isDebug,
@@ -267,7 +262,6 @@ class Dart2jsCompilerConfiguration extends Dart2xCompilerConfiguration {
if (isDebug) multiplier *= 4;
if (isChecked) multiplier *= 2;
if (isHostChecked) multiplier *= 16;
- if (isBrowser) multiplier *= 2; // TODO(26060): Remove when issue fixed.
return multiplier;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698