Issue 1874613002: relnote: add connection option "SPSH" to indicate whether client wants to do server push or not, wh…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1874613002: relnote: add connection option "SPSH" to indicate whether client wants to do server push or not, wh… (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi

Modified:
4 years, 8 months ago

Reviewers:
ramant (doing other things), Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, danzh1

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

relnote: add connection option "SPSH" to indicate whether client wants to do server push or not, which is disabled by default on server. Move "SPSH" negotiation into shared code. Merge internal change: 118974770 BUG=

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -2 lines)			Patch
M	net/quic/crypto/crypto_protocol.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/tools/quic/quic_server_session_base.h	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_server_session_base.cc	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	net/tools/quic/quic_server_session_base_test.cc	View	2 chunks	+19 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_simple_server_session.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/tools/quic/quic_simple_server_session_test.cc	View	2 chunks	+5 lines, -1 line	0 comments	Download

Dependent Patchsets:

Issue 1873673002 Patch 1

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages