Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1874603002: [Android] Remove host-driven test framework. (Closed)

Created:
4 years, 8 months ago by jbudorick
Modified:
4 years, 8 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove host-driven test framework. BUG=478292 TBR=thakis@chromium.org Committed: https://crrev.com/39532fb01e50c10783b90a2f4e121ae307334414 Cr-Commit-Position: refs/heads/master@{#385952}

Patch Set 1 #

Total comments: 1

Patch Set 2 : update chrome/android/java_sources.gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -984 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D base/test/android/javatests/src/org/chromium/base/test/util/HostDrivenTest.java View 1 chunk +0 lines, -22 lines 0 comments Download
D build/android/pylib/host_driven/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
D build/android/pylib/host_driven/setup.py View 1 chunk +0 lines, -200 lines 0 comments Download
D build/android/pylib/host_driven/test_case.py View 1 chunk +0 lines, -192 lines 0 comments Download
D build/android/pylib/host_driven/test_info_collection.py View 1 chunk +0 lines, -139 lines 0 comments Download
D build/android/pylib/host_driven/test_runner.py View 1 chunk +0 lines, -133 lines 0 comments Download
D build/android/pylib/host_driven/test_server.py View 1 chunk +0 lines, -131 lines 0 comments Download
D build/android/pylib/host_driven/tests_annotations.py View 1 chunk +0 lines, -94 lines 0 comments Download
M build/android/test_runner.py View 3 chunks +4 lines, -10 lines 0 comments Download
M build/android/test_runner.pydeps View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/android/host_driven_tests/DummyTest.py View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/android/host_driven_tests/OWNERS View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java_sources.gni View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/test/DummyTest.java View 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
jbudorick
blocked on a downstream CL https://codereview.chromium.org/1874603002/diff/1/build/android/test_runner.py File build/android/test_runner.py (right): https://codereview.chromium.org/1874603002/diff/1/build/android/test_runner.py#newcode766 build/android/test_runner.py:766: py_runner_factory = None Setting ...
4 years, 8 months ago (2016-04-08 00:25:35 UTC) #2
rnephew (Reviews Here)
On 2016/04/08 00:25:35, jbudorick wrote: > blocked on a downstream CL > > https://codereview.chromium.org/1874603002/diff/1/build/android/test_runner.py > ...
4 years, 8 months ago (2016-04-08 00:27:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874603002/1
4 years, 8 months ago (2016-04-08 01:03:25 UTC) #5
jbudorick
+newt, dfalcantara for chrome/android/ owners
4 years, 8 months ago (2016-04-08 01:04:10 UTC) #7
gone
\o/ lgtm
4 years, 8 months ago (2016-04-08 01:05:19 UTC) #9
jbudorick
TBR thakis: owners for trivial change to base/BUILD.gn
4 years, 8 months ago (2016-04-08 01:08:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874603002/1
4 years, 8 months ago (2016-04-08 01:09:20 UTC) #14
newt (away)
:)
4 years, 8 months ago (2016-04-08 01:09:28 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/47691) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 01:20:07 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874603002/20001
4 years, 8 months ago (2016-04-08 01:37:44 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 02:57:55 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 03:00:20 UTC) #23
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/39532fb01e50c10783b90a2f4e121ae307334414
Cr-Commit-Position: refs/heads/master@{#385952}

Powered by Google App Engine
This is Rietveld 408576698