Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: server/logdog/storage/bigtable/bigtable_test.go

Issue 1874563005: Archivist asserts completeness through keys scan. (Closed) Base URL: https://github.com/luci/luci-go@logdog-storage-keysonly
Patch Set: Remove unused members. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « server/logdog/storage/bigtable/bigtable.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: server/logdog/storage/bigtable/bigtable_test.go
diff --git a/server/logdog/storage/bigtable/bigtable_test.go b/server/logdog/storage/bigtable/bigtable_test.go
index 89b50efc630af05b4bed2fb41ab1369dfe06cc41..71b50668aa35eceb514adf0980a3ba56206c3195 100644
--- a/server/logdog/storage/bigtable/bigtable_test.go
+++ b/server/logdog/storage/bigtable/bigtable_test.go
@@ -9,7 +9,6 @@ import (
"time"
"github.com/luci/luci-go/common/errors"
- "github.com/luci/luci-go/common/grpcutil"
"github.com/luci/luci-go/server/logdog/storage"
"golang.org/x/net/context"
"google.golang.org/cloud/bigtable"
@@ -85,21 +84,3 @@ func TestBigTable(t *testing.T) {
})
})
}
-
-func TestBigTableErrors(t *testing.T) {
- t.Parallel()
-
- Convey(`A nil error is not marked transient.`, t, func() {
- So(wrapTransient(nil), ShouldBeNil)
- })
-
- Convey(`A regular error is not marked transient.`, t, func() {
- So(grpcutil.IsTransient(grpcutil.Canceled), ShouldBeFalse)
- So(errors.IsTransient(wrapTransient(grpcutil.Canceled)), ShouldBeFalse)
- })
-
- Convey(`An gRPC transient error is marked transient.`, t, func() {
- So(grpcutil.IsTransient(grpcutil.Internal), ShouldBeTrue)
- So(errors.IsTransient(wrapTransient(grpcutil.Internal)), ShouldBeTrue)
- })
-}
« no previous file with comments | « server/logdog/storage/bigtable/bigtable.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698