Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1874553002: Dart: Fix bug in unbind() for Stubs. (Closed)

Created:
4 years, 8 months ago by zra
Modified:
4 years, 8 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Fix bug in unbind() for Stubs. The MojoHandleWatcher.remove() in MojoEventSubscription's unsubscribe() call can race with the removal of a handle from the handle watcher for an arriving event. This CL adds a test that recreates this situation, and removes an assert that fires when it happens. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/aaeb3451ba80ead4583ee24773562aee4ef83ef5

Patch Set 1 #

Patch Set 2 : Fix analyzer message #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -3 lines) Patch
M mojo/dart/apptests/dart_apptests/lib/src/echo_apptests.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M mojo/dart/apptests/test_apps/echo/lib/main.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M mojo/dart/apptests/test_apps/echo_with_service_describer/lib/main.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/dart/apptests/test_apps/interfaces/echo_service.mojom View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/dart/packages/_mojo_for_test_only/lib/test/echo_service.mojom.dart View 6 chunks +73 lines, -2 lines 0 comments Download
M mojo/public/platform/dart/dart_handle_watcher.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
4 years, 8 months ago (2016-04-07 21:55:30 UTC) #3
Cutch
lgtm
4 years, 8 months ago (2016-04-13 19:59:16 UTC) #4
zra
4 years, 8 months ago (2016-04-14 21:34:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
aaeb3451ba80ead4583ee24773562aee4ef83ef5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698