Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1874493002: [Autofill] Add user actions for checkout flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
705 705
706 if (is_new_popup) { 706 if (is_new_popup) {
707 AutofillMetrics::LogUserHappinessMetric(AutofillMetrics::SUGGESTIONS_SHOWN); 707 AutofillMetrics::LogUserHappinessMetric(AutofillMetrics::SUGGESTIONS_SHOWN);
708 708
709 if (!did_show_suggestions_) { 709 if (!did_show_suggestions_) {
710 did_show_suggestions_ = true; 710 did_show_suggestions_ = true;
711 AutofillMetrics::LogUserHappinessMetric( 711 AutofillMetrics::LogUserHappinessMetric(
712 AutofillMetrics::SUGGESTIONS_SHOWN_ONCE); 712 AutofillMetrics::SUGGESTIONS_SHOWN_ONCE);
713 } 713 }
714 714
715 if (autofill_field->Type().group() == CREDIT_CARD) 715 if (autofill_field->Type().group() == CREDIT_CARD)
Mathieu 2016/04/11 16:45:45 we will need brackets if we have multiple lines in
sebsg 2016/04/12 14:40:59 Done.
716 credit_card_form_event_logger_->OnDidShowSuggestions(); 716 credit_card_form_event_logger_->OnDidShowSuggestions(
Mathieu 2016/04/11 16:45:45 FormEventLogger is constructed with |is_for_credit
sebsg 2016/04/12 14:40:59 Done.
717 true /* is_credit_card */);
717 else 718 else
718 address_form_event_logger_->OnDidShowSuggestions(); 719 address_form_event_logger_->OnDidShowSuggestions(
720 false /* is_credit_card */);
719 } 721 }
720 } 722 }
721 723
722 void AutofillManager::OnHidePopup() { 724 void AutofillManager::OnHidePopup() {
723 if (!IsAutofillEnabled()) 725 if (!IsAutofillEnabled())
724 return; 726 return;
725 727
726 autocomplete_history_manager_->CancelPendingQuery(); 728 autocomplete_history_manager_->CancelPendingQuery();
727 client_->HideAutofillPopup(); 729 client_->HideAutofillPopup();
728 } 730 }
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1998 if (i > 0) 2000 if (i > 0)
1999 fputs("Next oldest form:\n", file); 2001 fputs("Next oldest form:\n", file);
2000 } 2002 }
2001 fputs("\n", file); 2003 fputs("\n", file);
2002 2004
2003 fclose(file); 2005 fclose(file);
2004 } 2006 }
2005 #endif // ENABLE_FORM_DEBUG_DUMP 2007 #endif // ENABLE_FORM_DEBUG_DUMP
2006 2008
2007 } // namespace autofill 2009 } // namespace autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698