Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: chrome/browser/memory_details.h

Issue 1874483002: Remove "from all browsers" memory details mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rip out ProcessInfoSnapshot Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory_details.h
diff --git a/chrome/browser/memory_details.h b/chrome/browser/memory_details.h
index c8820e774e9eba6e1a2a4e644cea5602824e6728..9b2d491c7120e9fecfccfdff3ab8049dabbe7559 100644
--- a/chrome/browser/memory_details.h
+++ b/chrome/browser/memory_details.h
@@ -112,20 +112,13 @@ struct ProcessData {
// }
class MemoryDetails : public base::RefCountedThreadSafe<MemoryDetails> {
public:
- enum CollectionMode {
- // Collect metrics from Chrome and other running browsers.
- FROM_ALL_BROWSERS,
- // Collect metrics from Chrome processes only.
- FROM_CHROME_ONLY
- };
-
// Constructor.
MemoryDetails();
- // Initiate updating the current memory details (based on |mode|). These are
- // fetched asynchronously because data must be collected from multiple
- // threads. OnDetailsAvailable will be called when this process is complete.
- void StartFetch(CollectionMode mode);
+ // Initiate updating the current memory details. These are fetched
+ // asynchronously because data must be collected from multiple threads.
+ // OnDetailsAvailable will be called when this process is complete.
+ void StartFetch();
virtual void OnDetailsAvailable() = 0;
@@ -138,6 +131,7 @@ class MemoryDetails : public base::RefCountedThreadSafe<MemoryDetails> {
virtual ~MemoryDetails();
+
Nico 2016/04/08 19:47:44 (nit: needless new newline)
Elly Fong-Jones 2016/04/13 17:18:24 Done.
// Access to the process detail information. This data is only available
// after OnDetailsAvailable() has been called.
const std::vector<ProcessData>& processes() { return process_data_; }
@@ -155,7 +149,7 @@ class MemoryDetails : public base::RefCountedThreadSafe<MemoryDetails> {
// on that thread. The data will be used by about:memory. When finished,
// invokes back to the file thread to run the rest of the about:memory
// functionality.
- void CollectChildInfoOnIOThread(CollectionMode mode);
+ void CollectChildInfoOnIOThread();
// Collect current process information from the OS and store it
// for processing. If data has already been collected, clears old
@@ -164,7 +158,6 @@ class MemoryDetails : public base::RefCountedThreadSafe<MemoryDetails> {
// and is fairly expensive to run, hence it's run on the blocking pool.
// The parameter holds information about processes from the IO thread.
void CollectProcessData(
- CollectionMode mode,
const std::vector<ProcessMemoryInformation>& child_info);
// Collect child process information on the UI thread. Information about

Powered by Google App Engine
This is Rietveld 408576698