chrome/browser/ui/webui/foreign_session_handler.cc - Issue 1874473004: MD History: Support dynamically updating synced tab data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/foreign_session_handler.cc

Issue 1874473004: MD History: Support dynamically updating synced tab data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix indent Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/synced_device_manager.js ('k') | chrome/test/data/webui/md_history/history_synced_tabs_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/foreign_session_handler.cc

diff --git a/chrome/browser/ui/webui/foreign_session_handler.cc b/chrome/browser/ui/webui/foreign_session_handler.cc

index c4eafcecf0cac8ae01aa6a58126efab12ce43be4..f1b5df767ebd3f0fc8b430b5b1a93528c04f4ed1 100644

--- a/chrome/browser/ui/webui/foreign_session_handler.cc

+++ b/chrome/browser/ui/webui/foreign_session_handler.cc

@@ -279,14 +279,15 @@ void ForeignSessionHandler::HandleGetForeignSessions(

scoped_ptr<base::DictionaryValue> session_data(

new base::DictionaryValue());

// The items which are to be written into |session_data| are also

- // described in chrome/browser/resources/ntp4/other_sessions.js in

- // @typedef for SessionData. Please update it whenever you add or remove

- // any keys here.

+ // described in chrome/browser/resources/history/externs.js

+ // @typedef for ForeignSession. Please update it whenever you add or

+ // remove any keys here.

session_data->SetString("tag", session_tag);

session_data->SetString("name", session->session_name);

session_data->SetString("deviceType", session->DeviceTypeAsString());

session_data->SetString("modifiedTime",

FormatSessionTime(session->modified_time));

+ session_data->SetDouble("timestamp", session->modified_time.ToJsTime());

bool is_collapsed = collapsed_sessions->HasKey(session_tag);

session_data->SetBoolean("collapsed", is_collapsed);