Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1874473004: MD History: Support dynamically updating synced tab data (Closed)

Created:
4 years, 8 months ago by tsergeant
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Support dynamically updating synced tab data The history backend periodically sends updated tab data to the front-end page, which we use to update any existing devices and show new ones. Based off https://codereview.chromium.org/1619153002/ by yingran@google.com BUG=590958 Committed: https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977 Cr-Commit-Position: refs/heads/master@{#385974}

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Fix indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -30 lines) Patch
M chrome/browser/resources/history/externs.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/history.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_manager.js View 1 2 chunks +50 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 2 chunks +47 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tsergeant
dbeam@, please take a look!
4 years, 8 months ago (2016-04-08 01:48:00 UTC) #4
Dan Beam
lgtm https://codereview.chromium.org/1874473004/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc File chrome/browser/ui/webui/foreign_session_handler.cc (right): https://codereview.chromium.org/1874473004/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc#newcode291 chrome/browser/ui/webui/foreign_session_handler.cc:291: session->modified_time.ToJsTime()); indent off
4 years, 8 months ago (2016-04-08 01:52:01 UTC) #5
tsergeant
Thanks! https://codereview.chromium.org/1874473004/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc File chrome/browser/ui/webui/foreign_session_handler.cc (right): https://codereview.chromium.org/1874473004/diff/40001/chrome/browser/ui/webui/foreign_session_handler.cc#newcode291 chrome/browser/ui/webui/foreign_session_handler.cc:291: session->modified_time.ToJsTime()); On 2016/04/08 01:52:01, Dan Beam wrote: > ...
4 years, 8 months ago (2016-04-08 02:39:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874473004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874473004/60001
4 years, 8 months ago (2016-04-08 02:40:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 8 months ago (2016-04-08 03:20:33 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 03:22:51 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/82fc0fecbea601eef1bbc3a98f6e82286a473977
Cr-Commit-Position: refs/heads/master@{#385974}

Powered by Google App Engine
This is Rietveld 408576698