chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java - Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoScreen.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

index d26de7c92adc98de3c31e7efa9a3f6652b54cbcf..f3ffe3514c3e67cec728080ec089331a61d2c88f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/SearchEngineAdapter.java

@@ -10,7 +10,6 @@ import android.content.SharedPreferences;

import android.content.res.Resources;

import android.os.Build;

import android.os.Bundle;

-import android.preference.PreferenceManager;

import android.text.SpannableString;

import android.text.style.ForegroundColorSpan;

import android.view.LayoutInflater;

@@ -25,6 +24,7 @@ import android.widget.RadioButton;

import android.widget.TextView;

import org.chromium.base.ApiCompatibilityUtils;

+import org.chromium.base.ContextUtils;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.omnibox.geo.GeolocationHeader;

import org.chromium.chrome.browser.preferences.website.ContentSetting;

@@ -247,7 +247,7 @@ public class SearchEngineAdapter extends BaseAdapter implements LoadListener, On

// First clean up any automatically added permissions (if any) for the previously selected

// search engine.

SharedPreferences sharedPreferences =

- PreferenceManager.getDefaultSharedPreferences(mContext);

+ ContextUtils.getAppSharedPreferences();

if (sharedPreferences.getBoolean(PrefServiceBridge.LOCATION_AUTO_ALLOWED, false)) {

if (locationEnabled(mSelectedSearchEnginePosition, false)) {

String url = TemplateUrlService.getInstance().getSearchEngineUrlFromTemplateUrl(