chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java - Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java

index e50678b4389b19f48f7b9144597b2c2e7faa4649..feae9ba2a76609b44f0289686b73451bc945b1c3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/precache/PrecacheController.java

@@ -15,7 +15,6 @@ import android.os.Handler;

import android.os.Looper;

import android.os.PowerManager;

import android.os.PowerManager.WakeLock;

-import android.preference.PreferenceManager;

import com.google.android.gms.common.ConnectionResult;

import com.google.android.gms.common.GoogleApiAvailability;

@@ -23,6 +22,7 @@ import com.google.android.gms.gcm.GcmNetworkManager;

import com.google.android.gms.gcm.OneoffTask;

import com.google.android.gms.gcm.PeriodicTask;

+import org.chromium.base.ContextUtils;

import org.chromium.base.Log;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.library_loader.LibraryLoader;

@@ -229,7 +229,7 @@ public class PrecacheController {

@VisibleForTesting

boolean isPrecachingEnabled() {

assert mNonThreadSafe.calledOnValidThread();

- SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(mAppContext);

+ SharedPreferences prefs = ContextUtils.getAppSharedPreferences();

return prefs.getBoolean(PREF_IS_PRECACHING_ENABLED, false);

}

@@ -250,7 +250,7 @@ public class PrecacheController {

boolean cancelRequired = !enabled && PrecacheController.hasInstance();

Context appContext = context.getApplicationContext();

Log.v(TAG, "setting precache enabled to %s", enabled);

- Editor editor = PreferenceManager.getDefaultSharedPreferences(appContext).edit();

+ Editor editor = ContextUtils.getAppSharedPreferences().edit();

editor.putBoolean(PREF_IS_PRECACHING_ENABLED, enabled);

editor.apply();