chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java - Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationService.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java

index 53dd01c87293747abb3061f33c92aaded48c9c51..d08822167520e7073d5af351443342c67ac54974 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/metrics/StartupMetrics.java

@@ -4,12 +4,10 @@

package org.chromium.chrome.browser.metrics;

-import android.content.Context;

import android.content.Intent;

import android.os.Handler;

-import android.preference.PreferenceManager;

-import org.chromium.base.ApplicationStatus;

+import org.chromium.base.ContextUtils;

import org.chromium.base.metrics.RecordHistogram;

/**

@@ -124,8 +122,7 @@ public class StartupMetrics {

"MobileStartup.NonMainIntentAction";

RecordHistogram.recordEnumeratedHistogram(histogramName, mFirstActionTaken, MAX_INDEX);

mShouldRecordHistogram = false;

- Context ctx = ApplicationStatus.getApplicationContext();

- long lastUsedTimeMilli = PreferenceManager.getDefaultSharedPreferences(ctx).getLong(

+ long lastUsedTimeMilli = ContextUtils.getAppSharedPreferences().getLong(

UmaSessionStats.LAST_USED_TIME_PREF, 0);

if (mIsMainIntent && (lastUsedTimeMilli > 0) && (mStartTimeMilli > lastUsedTimeMilli)

&& (mStartTimeMilli - lastUsedTimeMilli > Integer.MAX_VALUE)) {