Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4049)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
index 25492ae764684872d5175a2a1cbb436eda25b4dc..16fd04118887ad795bc87c7c25fd34a8a6b79a73 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
@@ -10,12 +10,12 @@ import android.content.Context;
import android.content.Intent;
import android.content.SharedPreferences;
import android.net.Uri;
-import android.preference.PreferenceManager;
import android.provider.Browser;
import android.text.TextUtils;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.CommandLine;
+import org.chromium.base.ContextUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.RecordUserAction;
@@ -172,7 +172,7 @@ public class BookmarkUtils {
* {@link #getLastUsedUrl(Context)}
*/
static void setLastUsedUrl(Context context, String url) {
- PreferenceManager.getDefaultSharedPreferences(context).edit()
+ ContextUtils.getAppSharedPreferences().edit()
.putString(PREF_LAST_USED_URL, url).apply();
}
@@ -181,7 +181,7 @@ public class BookmarkUtils {
*/
@VisibleForTesting
static String getLastUsedUrl(Context context) {
- return PreferenceManager.getDefaultSharedPreferences(context).getString(
+ return ContextUtils.getAppSharedPreferences().getString(
PREF_LAST_USED_URL, UrlConstants.BOOKMARKS_URL);
}
@@ -189,7 +189,7 @@ public class BookmarkUtils {
* Save the last used {@link BookmarkId} as a folder to put new bookmarks to.
*/
static void setLastUsedParent(Context context, BookmarkId bookmarkId) {
- PreferenceManager.getDefaultSharedPreferences(context).edit()
+ ContextUtils.getAppSharedPreferences().edit()
.putString(PREF_LAST_USED_PARENT, bookmarkId.toString()).apply();
}
@@ -198,7 +198,7 @@ public class BookmarkUtils {
* has never selected a parent folder to use.
*/
static BookmarkId getLastUsedParent(Context context) {
- SharedPreferences preferences = PreferenceManager.getDefaultSharedPreferences(context);
+ SharedPreferences preferences = ContextUtils.getAppSharedPreferences();
if (!preferences.contains(PREF_LAST_USED_PARENT)) return null;
return BookmarkId.getBookmarkIdFromString(

Powered by Google App Engine
This is Rietveld 408576698