Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java

Issue 1874423002: 🍰 Migrate app shared preferences to ContextUtils. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
index e2cef086e6d36046542030fe27ff4c1b2ee3098e..1d95c3a4cb24f16f9ef8084098f91f7ebf59ffe3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPromoHeader.java
@@ -6,11 +6,11 @@ package org.chromium.chrome.browser.bookmarks;
import android.content.Context;
import android.content.SharedPreferences;
-import android.preference.PreferenceManager;
import android.support.v7.widget.RecyclerView;
import android.support.v7.widget.RecyclerView.ViewHolder;
import android.view.ViewGroup;
+import org.chromium.base.ContextUtils;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.browser.signin.SigninAccessPoint;
import org.chromium.chrome.browser.signin.SigninAndSyncView;
@@ -64,9 +64,9 @@ class BookmarkPromoHeader implements AndroidSyncSettingsObserver,
updateShouldShow(false);
if (shouldShow()) {
- int promoShowCount = PreferenceManager.getDefaultSharedPreferences(mContext)
+ int promoShowCount = ContextUtils.getAppSharedPreferences()
.getInt(PREF_SIGNIN_PROMO_SHOW_COUNT, 0) + 1;
- PreferenceManager.getDefaultSharedPreferences(mContext).edit()
+ ContextUtils.getAppSharedPreferences().edit()
.putInt(PREF_SIGNIN_PROMO_SHOW_COUNT, promoShowCount).apply();
RecordUserAction.record("Stars_SignInPromoHeader_Displayed");
RecordUserAction.record("Signin_Impression_FromBookmarkManager");
@@ -112,7 +112,7 @@ class BookmarkPromoHeader implements AndroidSyncSettingsObserver,
* @return Whether user tapped "No" button on the signin promo header.
*/
private boolean wasSigninPromoDeclined() {
- return PreferenceManager.getDefaultSharedPreferences(mContext).getBoolean(
+ return ContextUtils.getAppSharedPreferences().getBoolean(
PREF_SIGNIN_PROMO_DECLINED, false);
}
@@ -121,7 +121,7 @@ class BookmarkPromoHeader implements AndroidSyncSettingsObserver,
*/
private void setSigninPromoDeclined() {
SharedPreferences.Editor sharedPreferencesEditor =
- PreferenceManager.getDefaultSharedPreferences(mContext).edit();
+ ContextUtils.getAppSharedPreferences().edit();
sharedPreferencesEditor.putBoolean(PREF_SIGNIN_PROMO_DECLINED, true);
sharedPreferencesEditor.apply();
}
@@ -131,7 +131,7 @@ class BookmarkPromoHeader implements AndroidSyncSettingsObserver,
mShouldShow = AndroidSyncSettings.isMasterSyncEnabled(mContext)
&& mSignInManager.isSignInAllowed()
&& !wasSigninPromoDeclined()
- && PreferenceManager.getDefaultSharedPreferences(mContext).getInt(
+ && ContextUtils.getAppSharedPreferences().getInt(
PREF_SIGNIN_PROMO_SHOW_COUNT, 0) < MAX_SIGNIN_PROMO_SHOW_COUNT;
if (oldIsShowing != mShouldShow && notifyUI) {
mShowingChangeListener.onPromoHeaderShowingChanged(mShouldShow);

Powered by Google App Engine
This is Rietveld 408576698