Convert media/formats to std::unique_ptr

Convert media/formats to std::unique_ptr

BUG=554298
Committed: https://crrev.com/f402ab9f3f02d00d87c840fe79863f4ac0609ba1
Cr-Commit-Position: refs/heads/master@{#387059}

[Nico, 2016-04-11 18:45:53]

Description was changed from

==========
Convert media/filters to std::unique_ptr

BUG=554298
==========

to

==========
Convert media/formats to std::unique_ptr

BUG=554298
==========

[Nico, 2016-04-11 18:46:36]

thakis@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-04-11 18:56:43]

lg with one question

https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
File media/formats/common/offset_byte_queue_unittest.cc (right):

https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
media/formats/common/offset_byte_queue_unittest.cc:5: #include
"media/formats/common/offset_byte_queue.h"
Where's the rule that this header should be the first include for tests? We are
not doing this in media/ today.

[Nico, 2016-04-11 19:00:01]

https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
File media/formats/common/offset_byte_queue_unittest.cc (right):

https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
media/formats/common/offset_byte_queue_unittest.cc:5: #include
"media/formats/common/offset_byte_queue.h"
On 2016/04/11 18:56:43, xhwang wrote:
> Where's the rule that this header should be the first include for tests? We
are
> not doing this in media/ today.

dcheng's script for adding these puts them there. dcheng, why?

(feels like most unittests include the .h being tested first though)

[dcheng, 2016-04-13 15:11:37]

On 2016/04/11 at 19:00:01, thakis wrote:
>
https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
> File media/formats/common/offset_byte_queue_unittest.cc (right):
> 
>
https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
> media/formats/common/offset_byte_queue_unittest.cc:5: #include
"media/formats/common/offset_byte_queue.h"
> On 2016/04/11 18:56:43, xhwang wrote:
> > Where's the rule that this header should be the first include for tests? We
are
> > not doing this in media/ today.
> 
> dcheng's script for adding these puts them there. dcheng, why?
> 
> (feels like most unittests include the .h being tested first though)

This is mandated by the style guide in
http://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

  In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test
the stuff in dir2/foo2.h, order your includes as follows:
  1. dir2/foo2.h.
  2. C system files.
  3. C++ system files.
  4. Other libraries' .h files.
  5. Your project's .h files.

Note that in practice, we always merge #4 and #5.

[xhwang, 2016-04-13 17:20:49]

On 2016/04/13 15:11:37, dcheng wrote:
> On 2016/04/11 at 19:00:01, thakis wrote:
> >
>
https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
> > File media/formats/common/offset_byte_queue_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/1874413003/diff/1/media/formats/common/offset...
> > media/formats/common/offset_byte_queue_unittest.cc:5: #include
> "media/formats/common/offset_byte_queue.h"
> > On 2016/04/11 18:56:43, xhwang wrote:
> > > Where's the rule that this header should be the first include for tests?
We
> are
> > > not doing this in media/ today.
> > 
> > dcheng's script for adding these puts them there. dcheng, why?
> > 
> > (feels like most unittests include the .h being tested first though)
> 
> This is mandated by the style guide in
> http://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
> 
>   In dir/foo.cc or dir/foo_test.cc, whose main purpose is to implement or test
> the stuff in dir2/foo2.h, order your includes as follows:
>   1. dir2/foo2.h.
>   2. C system files.
>   3. C++ system files.
>   4. Other libraries' .h files.
>   5. Your project's .h files.
> 
> Note that in practice, we always merge #4 and #5.

Thanks a lot! Somehow I missed this one.

LGTM then!

[Nico, 2016-04-13 17:57:43]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-04-13 17:58:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874413003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874413003/1

[commit-bot: I haz the power, 2016-04-13 19:07:57]

Description was changed from

==========
Convert media/formats to std::unique_ptr

BUG=554298
==========

to

==========
Convert media/formats to std::unique_ptr

BUG=554298
==========

[commit-bot: I haz the power, 2016-04-13 19:07:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-13 19:09:43]

Description was changed from

==========
Convert media/formats to std::unique_ptr

BUG=554298
==========

to

==========
Convert media/formats to std::unique_ptr

BUG=554298

Committed: https://crrev.com/f402ab9f3f02d00d87c840fe79863f4ac0609ba1
Cr-Commit-Position: refs/heads/master@{#387059}
==========

[commit-bot: I haz the power, 2016-04-13 19:09:44]

Patchset 1 (id:??) landed as
https://crrev.com/f402ab9f3f02d00d87c840fe79863f4ac0609ba1
Cr-Commit-Position: refs/heads/master@{#387059}