Issue 18744: * Irregexp: Handle backtrack past look-ahead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18744: * Irregexp: Handle backtrack past look-ahead. (Closed)

Created:
11 years, 11 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

Irregexp: Backtrack past look-aheads works correctly. Allows backtracking to clear registers instead of pushing and popping them to restore state. Redo of 1136 with bug fixed.

Patch Set 1 #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+475 lines, -70 lines)			Patch
M	src/ast.h	View	2 chunks	+12 lines, -2 lines	0 comments	Download
M	src/jsregexp.h	View	6 chunks	+28 lines, -12 lines	0 comments	Download
M	src/jsregexp.cc	View	18 chunks	+146 lines, -41 lines	0 comments	Download
M	src/parser.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/regexp-macro-assembler.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-ia32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-ia32.cc	View	4 chunks	+25 lines, -5 lines	0 comments	Download
M	src/regexp-macro-assembler-irregexp.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-irregexp.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/regexp-macro-assembler-tracer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/regexp-macro-assembler-tracer.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A	test/mjsunit/regexp-capture.js	View	1 chunk	+52 lines, -0 lines	0 comments	Download
A	test/mjsunit/regexp-lookahead.js	View	1 chunk	+166 lines, -0 lines	0 comments	Download
A	test/mjsunit/regress/regress-187.js	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

Review, please. Only difference between this and 1135 is in jsregexp.cc line 1373. It incorrectly ...

11 years, 11 months ago (2009-01-26 10:10:37 UTC) #1

LGTM

Expand Messages | Collapse Messages