🏆 Allow Android test wrapper scripts to specify their timeouts in GN/GYP

Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=599919
Committed: https://crrev.com/3ac557f0d4da0c7fff4b554413bc784c1c63a260
Cr-Commit-Position: refs/heads/master@{#386696}

[agrieve, 2016-04-11 18:16:01]

agrieve@chromium.org changed reviewers:
+ dpranke@chromium.org, xunjieli@chromium.org

[agrieve, 2016-04-11 18:16:02]

xunjieli@chromium.org: Please review changes in cronet/, net/

dpranke@chromium.org: Please review changes in testing/, build/

[agrieve, 2016-04-11 18:16:55]

Description was changed from

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

BUG=none
==========

to

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=none
==========

[agrieve, 2016-04-11 19:52:21]

Description was changed from

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=none
==========

to

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=599919
==========

[Dirk Pranke, 2016-04-11 21:54:35]

lgtm

[xunjieli, 2016-04-12 02:13:17]

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp#newcode1584
net/net.gyp:1584: 'shard_timeout': 300,
Are these numbers same as what we have on all the bots?

[xunjieli, 2016-04-12 02:18:51]

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp#newcode1584
net/net.gyp:1584: 'shard_timeout': 300,
On 2016/04/12 02:13:17, xunjieli wrote:
> Are these numbers same as what we have on all the bots?

where does "300" come from? Why does cronet_unittests has timeout as 180
instead?

[agrieve, 2016-04-12 02:33:37]

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp#newcode1584
net/net.gyp:1584: 'shard_timeout': 300,
On 2016/04/12 02:18:51, xunjieli wrote:
> On 2016/04/12 02:13:17, xunjieli wrote:
> > Are these numbers same as what we have on all the bots?
> 
> where does "300" come from? Why does cronet_unittests has timeout as 180
> instead?

Good question.

Cronet & net are run here with a timeout of 180:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

But net is run here with a timeout of 300:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

So I used the bigger of the two (not positive that's the correct thing to do)

[xunjieli, 2016-04-12 02:40:28]

lgtm

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp
File net/net.gyp (right):

https://codereview.chromium.org/1874393002/diff/40001/net/net.gyp#newcode1584
net/net.gyp:1584: 'shard_timeout': 300,
On 2016/04/12 02:33:37, agrieve wrote:
> On 2016/04/12 02:18:51, xunjieli wrote:
> > On 2016/04/12 02:13:17, xunjieli wrote:
> > > Are these numbers same as what we have on all the bots?
> > 
> > where does "300" come from? Why does cronet_unittests has timeout as 180
> > instead?
> 
> Good question.
> 
> Cronet & net are run here with a timeout of 180:
>
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
> 
> But net is run here with a timeout of 300:
>
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...
> 
> So I used the bigger of the two (not positive that's the correct thing to do)

I see. I remembered there was some issue with timeouts (Some net unittests take
more than 100s. See crbug.com/540939). Since these timeout values are current
ones, so I think this will be fine.

[agrieve, 2016-04-12 13:48:23]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-12 13:48:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1874393002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1874393002/40001

[commit-bot: I haz the power, 2016-04-12 15:52:10]

Description was changed from

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=599919
==========

to

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=599919
==========

[commit-bot: I haz the power, 2016-04-12 15:52:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-12 15:53:13]

Description was changed from

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=599919
==========

to

==========
Allow Android test wrapper scripts to specify their timeouts in GN/GYP

The aim here is to make local runs use the same timeout as bots.

BUG=599919

Committed: https://crrev.com/3ac557f0d4da0c7fff4b554413bc784c1c63a260
Cr-Commit-Position: refs/heads/master@{#386696}
==========

[commit-bot: I haz the power, 2016-04-12 15:53:14]

Patchset 3 (id:??) landed as
https://crrev.com/3ac557f0d4da0c7fff4b554413bc784c1c63a260
Cr-Commit-Position: refs/heads/master@{#386696}