src/compiler/wasm-compiler.h - Issue 1874383002: [wasm] Throw real Error on wasm trap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/wasm-compiler.h

Issue 1874383002: [wasm] Throw real Error on wasm trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@trapreasons-to-messages

Patch Set: remove a TODO Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/wasm-compiler.h

diff --git a/src/compiler/wasm-compiler.h b/src/compiler/wasm-compiler.h

index ee03d5ea4413a45270accd184fca494a3d568af9..db1938a6f52033b9bed60fdb51a3935f2134448e 100644

--- a/src/compiler/wasm-compiler.h

+++ b/src/compiler/wasm-compiler.h

@@ -79,6 +79,7 @@ class WasmGraphBuilder {

Node* Merge(unsigned count, Node** controls);

Node* Phi(wasm::LocalType type, unsigned count, Node** vals, Node* control);

Node* EffectPhi(unsigned count, Node** effects, Node* control);

+ Node* NumberConstant(int32_t value);

Node* Int32Constant(int32_t value);

Node* Int64Constant(int64_t value);

Node* Float32Constant(float value);

« no previous file with comments | « no previous file | src/compiler/wasm-compiler.cc » ('j') | no next file with comments »