Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/runtime/runtime-internal.cc

Issue 1874383002: [wasm] Throw real Error on wasm trap (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@trapreasons-to-messages
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | test/mjsunit/wasm/unreachable.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/ast/prettyprinter.h" 8 #include "src/ast/prettyprinter.h"
9 #include "src/bootstrapper.h" 9 #include "src/bootstrapper.h"
10 #include "src/conversions.h" 10 #include "src/conversions.h"
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 return isolate->ReThrow(args[0]); 89 return isolate->ReThrow(args[0]);
90 } 90 }
91 91
92 92
93 RUNTIME_FUNCTION(Runtime_ThrowStackOverflow) { 93 RUNTIME_FUNCTION(Runtime_ThrowStackOverflow) {
94 SealHandleScope shs(isolate); 94 SealHandleScope shs(isolate);
95 DCHECK_LE(0, args.length()); 95 DCHECK_LE(0, args.length());
96 return isolate->StackOverflow(); 96 return isolate->StackOverflow();
97 } 97 }
98 98
99 RUNTIME_FUNCTION(Runtime_ThrowWasmError) {
100 HandleScope scope(isolate);
101 DCHECK_EQ(1, args.length());
102 CONVERT_SMI_ARG_CHECKED(message_id, 0);
103 // TODO(clemensh): discuss with titzer whether a WasmError class would make
titzer 2016/04/18 16:22:13 When in doubt, leave it out :-)
104 // sense here
105 THROW_NEW_ERROR_RETURN_FAILURE(
106 isolate, NewError(static_cast<MessageTemplate::Template>(message_id)));
107 }
99 108
100 RUNTIME_FUNCTION(Runtime_UnwindAndFindExceptionHandler) { 109 RUNTIME_FUNCTION(Runtime_UnwindAndFindExceptionHandler) {
101 SealHandleScope shs(isolate); 110 SealHandleScope shs(isolate);
102 DCHECK(args.length() == 0); 111 DCHECK(args.length() == 0);
103 return isolate->UnwindAndFindHandler(); 112 return isolate->UnwindAndFindHandler();
104 } 113 }
105 114
106 115
107 RUNTIME_FUNCTION(Runtime_PromoteScheduledException) { 116 RUNTIME_FUNCTION(Runtime_PromoteScheduledException) {
108 SealHandleScope shs(isolate); 117 SealHandleScope shs(isolate);
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
484 std::stringstream stats_stream; 493 std::stringstream stats_stream;
485 isolate->counters()->runtime_call_stats()->Print(stats_stream); 494 isolate->counters()->runtime_call_stats()->Print(stats_stream);
486 Handle<String> result = 495 Handle<String> result =
487 isolate->factory()->NewStringFromAsciiChecked(stats_stream.str().c_str()); 496 isolate->factory()->NewStringFromAsciiChecked(stats_stream.str().c_str());
488 isolate->counters()->runtime_call_stats()->Reset(); 497 isolate->counters()->runtime_call_stats()->Reset();
489 return *result; 498 return *result;
490 } 499 }
491 500
492 } // namespace internal 501 } // namespace internal
493 } // namespace v8 502 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | test/mjsunit/wasm/unreachable.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698