Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1874323002: PPC: [generators] Store the resume mode in the generator object. (Closed)

Created:
4 years, 8 months ago by MTBrandyberry
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [generators] Store the resume mode in the generator object. Port 2e3296666b04f0a038d9239a92e2ff39b5716f74 Original commit message: ... instead of doing stack magic. This is a cleanup in preparation for the new generators implementation. R=neis@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/3dab9ba7b95d5599e9640d785f18c0c5b99e1ab3 Cr-Commit-Position: refs/heads/master@{#35416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
PTAL
4 years, 8 months ago (2016-04-11 15:02:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874323002/1
4 years, 8 months ago (2016-04-11 15:02:34 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-11 15:20:05 UTC) #5
john.yan
lgtm
4 years, 8 months ago (2016-04-12 12:45:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874323002/1
4 years, 8 months ago (2016-04-12 13:49:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-12 14:01:23 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 14:02:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3dab9ba7b95d5599e9640d785f18c0c5b99e1ab3
Cr-Commit-Position: refs/heads/master@{#35416}

Powered by Google App Engine
This is Rietveld 408576698