Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1874313002: Convert device to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), ortuno+watch_chromium.org, qsr+mojo_chromium.org, scheib+watch_chromium.org, timvolodine, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert device to std::unique_ptr BUG=554298 Committed: https://crrev.com/acd68a2e07af43fa67def3830555f294eff2ac8e Cr-Commit-Position: refs/heads/master@{#386398}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -279 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_device.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/battery/battery_monitor_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M device/battery/battery_status_manager.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/battery/battery_status_manager_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M device/battery/battery_status_manager_default.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M device/battery/battery_status_manager_linux.cc View 6 chunks +19 lines, -18 lines 0 comments Download
M device/battery/battery_status_manager_mac.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M device/battery/battery_status_manager_win.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M device/battery/battery_status_service.h View 4 chunks +5 lines, -4 lines 0 comments Download
M device/battery/battery_status_service.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M device/battery/battery_status_service_unittest.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M device/bluetooth/dbus/bluetooth_adapter_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/bluetooth_media_endpoint_service_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_adapter_client.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/dbus/fake_bluetooth_gatt_descriptor_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/core/device_monitor_win.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M device/core/mock_device_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M device/hid/device_monitor_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/hid/device_monitor_linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/hid/hid_connection_linux.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M device/hid/hid_connection_mac.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M device/hid/hid_connection_unittest.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M device/hid/hid_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/hid/hid_service.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M device/hid/hid_service_linux.h View 2 chunks +7 lines, -5 lines 0 comments Download
M device/hid/hid_service_linux.cc View 9 chunks +11 lines, -8 lines 0 comments Download
M device/hid/hid_service_win.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M device/hid/hid_service_win.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M device/hid/input_service_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/hid/input_service_linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/media_transfer_protocol/media_transfer_protocol_manager.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M device/nfc/nfc_chromeos_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M device/nfc/nfc_ndef_record_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M device/nfc/nfc_ndef_record_utils_chromeos.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M device/nfc/nfc_tag_chromeos.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/serial/data_receiver.h View 3 chunks +4 lines, -2 lines 0 comments Download
M device/serial/data_receiver.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M device/serial/data_sink_receiver.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/serial/data_sink_receiver.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/serial/data_sink_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M device/serial/data_source_sender.h View 3 chunks +3 lines, -2 lines 0 comments Download
M device/serial/data_source_sender.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/serial/data_source_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M device/serial/serial_connection.h View 2 chunks +4 lines, -3 lines 0 comments Download
M device/serial/serial_connection.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M device/serial/serial_connection_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M device/serial/serial_device_enumerator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/serial/serial_device_enumerator_linux.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M device/serial/serial_device_enumerator_mac.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M device/serial/serial_device_enumerator_win.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M device/serial/serial_io_handler.h View 3 chunks +6 lines, -4 lines 0 comments Download
M device/serial/serial_io_handler.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M device/serial/serial_io_handler_win.h View 2 chunks +5 lines, -4 lines 0 comments Download
M device/serial/serial_service_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M device/serial/serial_service_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/serial/serial_service_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M device/test/test_device_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M device/test/usb_test_gadget.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/test/usb_test_gadget_impl.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M device/udev_linux/scoped_udev.h View 2 chunks +7 lines, -5 lines 0 comments Download
M device/udev_linux/udev0_loader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/udev_linux/udev1_loader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/udev_linux/udev_linux.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/udev_linux/udev_loader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M device/usb/mojo/device_impl.cc View 13 chunks +15 lines, -12 lines 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M device/usb/mojo/device_manager_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M device/usb/usb_context.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/usb/usb_descriptors.h View 2 chunks +4 lines, -4 lines 0 comments Download
M device/usb/usb_descriptors.cc View 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/usb_descriptors_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M device/usb/usb_device.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/usb_device_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/usb_device_filter.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M device/usb/usb_device_handle_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/usb_device_handle_impl.cc View 18 chunks +18 lines, -17 lines 0 comments Download
M device/usb/usb_device_handle_unittest.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M device/usb/usb_device_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M device/usb/usb_service.h View 2 chunks +2 lines, -2 lines 0 comments Download
M device/usb/usb_service.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M device/usb/usb_service_impl.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M device/usb/usb_service_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M device/usb/webusb_descriptors.cc View 6 chunks +10 lines, -7 lines 0 comments Download
M device/usb/webusb_descriptors_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
4 years, 8 months ago (2016-04-11 14:58:42 UTC) #2
Ken Rockot(use gerrit already)
rs lgtm
4 years, 8 months ago (2016-04-11 15:06:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874313002/60001
4 years, 8 months ago (2016-04-11 15:18:49 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-11 16:12:33 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 16:14:05 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/acd68a2e07af43fa67def3830555f294eff2ac8e
Cr-Commit-Position: refs/heads/master@{#386398}

Powered by Google App Engine
This is Rietveld 408576698