Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1874303002: Properly set up the code flags of the turbofan interceptor stubs. (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly set up the code flags of the turbofan interceptor stubs. Otherwise they can't be found in the megamorphic cache, leading to repeated misses. BUG=chromium:596825 LOG=n Committed: https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e Cr-Commit-Position: refs/heads/master@{#35393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M src/code-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/code-stubs.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Toon Verwaest
ptal
4 years, 8 months ago (2016-04-11 13:23:45 UTC) #2
Camillo Bruni
lgtm
4 years, 8 months ago (2016-04-11 13:28:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874303002/1
4 years, 8 months ago (2016-04-11 13:30:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13452)
4 years, 8 months ago (2016-04-11 13:36:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874303002/1
4 years, 8 months ago (2016-04-11 16:01:47 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 16:03:54 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 16:04:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39d121d1e3c334875052acda54f28551a89f6f3e
Cr-Commit-Position: refs/heads/master@{#35393}

Powered by Google App Engine
This is Rietveld 408576698