Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 187423003: Exclude quickoffice from android webview license check (Closed)

Created:
6 years, 9 months ago by boliu
Modified:
6 years, 9 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Exclude quickoffice from android webview license check BUG= NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M android_webview/tools/webview_licenses.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
boliu
6 years, 9 months ago (2014-03-06 17:23:15 UTC) #1
boliu
Oh, and failure log on bot: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/53318/steps/check_licenses/logs/stdio
6 years, 9 months ago (2014-03-06 17:23:29 UTC) #2
mnaganov (inactive)
lgtm
6 years, 9 months ago (2014-03-06 17:31:20 UTC) #3
Torne
lgtm
6 years, 9 months ago (2014-03-06 17:31:32 UTC) #4
dvh
On 2014/03/06 17:23:29, boliu wrote: > Oh, and failure log on bot: > http://build.chromium.org/p/chromium.linux/builders/Android%2520Builder%2520%2528dbg%2529/builds/53318/steps/check_licenses/logs/stdio lgtm.
6 years, 9 months ago (2014-03-06 17:32:38 UTC) #5
boliu
The CQ bit was checked by boliu@chromium.org
6 years, 9 months ago (2014-03-06 17:32:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/187423003/1
6 years, 9 months ago (2014-03-06 17:33:24 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 17:34:42 UTC) #8
Message was sent while issue was closed.
Change committed as 255383

Powered by Google App Engine
This is Rietveld 408576698