Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: build/common.gypi

Issue 187423002: Require SSE2 for all 32-bit Linux builds and remove disable_sse2 option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix qcms Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/qcms/qcms.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 28e3389b76fe724be78b51b54f52bc61a5c1b274..353d2762ce5ed0d36f1816860cb0240b3b2542d3 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -290,9 +290,6 @@
# The system libdir used for this ABI.
'system_libdir%': 'lib',
- # On Linux, we build with sse2 for Chromium builds.
- 'disable_sse2%': 0,
-
# Use libjpeg-turbo as the JPEG codec used by Chromium.
'use_libjpeg_turbo%': 1,
@@ -1667,13 +1664,6 @@
'disable_glibc%': 0,
}],
- # Disable SSE2 when building for ARM or MIPS.
- ['target_arch=="arm" or target_arch=="mipsel"', {
- 'disable_sse2%': 1,
- }, {
- 'disable_sse2%': '<(disable_sse2)',
- }],
-
# Set the relative path from this file to the GYP file of the JPEG
# library used by Chromium.
['use_system_libjpeg==1 or use_libjpeg_turbo==0', {
@@ -3208,24 +3198,21 @@
# value used during computation does not change depending on
# how the compiler optimized the code, since the value is
# always kept in its specified precision.
+ #
+ # Refer to http://crbug.com/348761 for rationale behind SSE2
+ # being a minimum requirement for 32-bit Linux builds and
+ # http://crbug.com/313032 for an example where this has "bit"
+ # us in the past.
+ 'cflags': [
+ '-msse2',
+ '-mfpmath=sse',
+ '-mmmx', # Allows mmintrin.h for MMX intrinsics.
+ '-m32',
+ ],
+ 'ldflags': [
+ '-m32',
+ ],
'conditions': [
- ['branding=="Chromium" and disable_sse2==0', {
- 'cflags': [
- '-march=pentium4',
- '-msse2',
- '-mfpmath=sse',
- ],
- }],
- # ChromeOS targets Pinetrail, which is sse3, but most of the
- # benefit comes from sse2 so this setting allows ChromeOS
- # to build on other CPUs. In the future -march=atom would
- # help but requires a newer compiler.
- ['chromeos==1 and disable_sse2==0', {
- 'cflags': [
- '-msse2',
- '-mfpmath=sse',
- ],
- }],
# Use gold linker for Android ia32 target.
['OS=="android"', {
'cflags': [
@@ -3247,15 +3234,6 @@
],
}],
],
- # -mmmx allows mmintrin.h to be used for mmx intrinsics.
- # video playback is mmx and sse2 optimized.
- 'cflags': [
- '-m32',
- '-mmmx',
- ],
- 'ldflags': [
- '-m32',
- ],
}],
],
}],
« no previous file with comments | « no previous file | third_party/qcms/qcms.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698