Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: third_party/qcms/qcms.gyp

Issue 187423002: Require SSE2 for all 32-bit Linux builds and remove disable_sse2 option. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove -march=pentium4 Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 'target_name': 'qcms', 8 'target_name': 'qcms',
9 'product_name': 'qcms', 9 'product_name': 'qcms',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 12 matching lines...) Expand all
23 ], 23 ],
24 'direct_dependent_settings': { 24 'direct_dependent_settings': {
25 'include_dirs': [ 25 'include_dirs': [
26 './src', 26 './src',
27 ], 27 ],
28 }, 28 },
29 # Warning (sign-conversion) fixed upstream by large refactoring. Can be 29 # Warning (sign-conversion) fixed upstream by large refactoring. Can be
30 # removed on next roll. 30 # removed on next roll.
31 'msvs_disabled_warnings': [ 4018 ], 31 'msvs_disabled_warnings': [ 4018 ],
32 32
33 'variables': {
34 'conditions': [
35 # For x86, turn off SSE2 for non-CrOS *nix Chrome builds.
36 ['disable_sse2==1 or \
37 (branding=="Chrome" and target_arch=="ia32" and \
38 os_posix==1 and OS!="mac" and chromeos==0)', {
39 'qcms_use_sse': 0,
40 }, {
41 'qcms_use_sse': 1,
42 }],
43 ],
44 },
45
46 'conditions': [ 33 'conditions': [
47 [ 'qcms_use_sse==1', { 34 ['target_arch=="ia32" or target_arch=="x64"', {
48 'defines': [ 35 'defines': [
49 'SSE2_ENABLE', 36 'SSE2_ENABLE',
50 ], 37 ],
51 'sources': [ 38 'sources': [
52 'src/transform-sse1.c', 39 'src/transform-sse1.c',
53 'src/transform-sse2.c', 40 'src/transform-sse2.c',
54 ], 41 ],
55 }], 42 }],
56 # MSVC x64 doesn't support the MMX intrinsics present in the SSE1 code, 43 # MSVC x64 doesn't support the MMX intrinsics present in the SSE1 code,
jamesr 2014/03/11 00:45:57 when would we ever use sse1? we use sse2 on all p
scherkus (not reviewing) 2014/03/11 18:31:01 ah right -- I forgot that bit about vs2013 and ass
57 # but that's OK since qcms prefers using SSE2 when available. 44 # but that's OK since qcms prefers using SSE2 when available.
58 [ 'qcms_use_sse==1 and OS=="win" and target_arch=="x64"', { 45 [ 'OS=="win" and target_arch=="x64"', {
59 'sources!': [ 46 'sources!': [
60 'src/transform-sse1.c', 47 'src/transform-sse1.c',
61 ], 48 ],
62 }], 49 }],
63 ['OS == "win" and (MSVS_VERSION == "2013" or MSVS_VERSION == "2013e")', { 50 ['OS == "win" and (MSVS_VERSION == "2013" or MSVS_VERSION == "2013e")', {
64 'msvs_disabled_warnings': [ 51 'msvs_disabled_warnings': [
65 4056, # overflow in floating-point constant arithmetic (INFINITY) 52 4056, # overflow in floating-point constant arithmetic (INFINITY)
66 4756, # overflow in constant arithmetic (INFINITY) 53 4756, # overflow in constant arithmetic (INFINITY)
67 ], 54 ],
68 }], 55 }],
69 ], 56 ],
70 }, 57 },
71 ], 58 ],
72 } 59 }
73 60
74 # Local Variables: 61 # Local Variables:
75 # tab-width:2 62 # tab-width:2
76 # indent-tabs-mode:nil 63 # indent-tabs-mode:nil
77 # End: 64 # End:
78 # vim: set expandtab tabstop=2 shiftwidth=2: 65 # vim: set expandtab tabstop=2 shiftwidth=2:
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698