Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 18742: Experimental: cleanup of the code generator source file. Some simple... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Experimental: cleanup of the code generator source file. Some simple formatting changes, and external issue numbers attached to TODOs. Committed: http://code.google.com/p/v8/source/detail?r=1144

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -147 lines) Patch
M src/codegen-ia32.cc View 19 chunks +193 lines, -147 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 11 months ago (2009-01-26 09:39:51 UTC) #1
William Hesse
LGTM, with comments. http://codereview.chromium.org/18742/diff/1/2 File src/codegen-ia32.cc (left): http://codereview.chromium.org/18742/diff/1/2#oldcode846 Line 846: exit()->Jump(); The other change list ...
11 years, 11 months ago (2009-01-26 10:07:50 UTC) #2
Kevin Millikin (Chromium)
11 years, 11 months ago (2009-01-26 10:35:59 UTC) #3
http://codereview.chromium.org/18742/diff/1/2
File src/codegen-ia32.cc (left):

http://codereview.chromium.org/18742/diff/1/2#oldcode846
Line 846: exit()->Jump();
On 2009/01/26 10:07:50, William Hesse wrote:
> The other change list returns a result through Jump(&result), as is done the
> deferred addition and subtraction cases.
> Should that be done here, or when the change is merged in?

This is spilled code jumping into spilled code, so I won't bother.

Powered by Google App Engine
This is Rietveld 408576698