Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1874153002: Roll HarfBuzz to 1.2.6 (Closed)

Created:
4 years, 8 months ago by kojii
Modified:
4 years, 8 months ago
Reviewers:
drott, eae, behdad
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll HarfBuzz to 1.2.6 Following Behdad's recommendation to pull this version. Removed hb-directwrite.* as they are not used, as per crrev.com/1867053004#msg18 BUG=601528 Committed: https://crrev.com/fcbabe31b76d0b8e783ceeb319d7e2fa116889c7 Cr-Commit-Position: refs/heads/master@{#386413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+694 lines, -1213 lines) Patch
M third_party/harfbuzz-ng/NEWS View 1 chunk +87 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/README View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/README.chromium View 2 chunks +7 lines, -19 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer.cc View 2 chunks +2 lines, -70 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-buffer-private.hh View 4 chunks +47 lines, -18 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-coretext.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-deprecated.h View 1 chunk +10 lines, -0 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-directwrite.h View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/harfbuzz-ng/src/hb-directwrite.cc View 1 chunk +0 lines, -827 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-fallback-shape.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.h View 5 chunks +43 lines, -12 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font.cc View 3 chunks +206 lines, -14 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-font-private.hh View 3 chunks +18 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ft.cc View 2 chunks +25 lines, -13 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-icu.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-open-type-private.hh View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-cmap-table.hh View 4 chunks +66 lines, -59 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-font.cc View 6 chunks +76 lines, -27 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-glyf-table.hh View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-hmtx-table.hh View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-layout-gsub-table.hh View 1 chunk +20 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-map.cc View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape.cc View 7 chunks +3 lines, -61 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-default.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-indic.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-myanmar.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-private.hh View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-thai.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-complex-use.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-fallback.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-private.hh View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/harfbuzz-ng/src/hb-unicode-private.hh View 1 chunk +1 line, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-version.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kojii
This CL is: 1. Applied your 1.2.5 roll crrev.com/1867053004 2. Rebased and resolved merge conflicts ...
4 years, 8 months ago (2016-04-10 14:52:39 UTC) #3
behdad
lgtm
4 years, 8 months ago (2016-04-10 17:54:40 UTC) #5
drott
LGTM, let's use this one then.
4 years, 8 months ago (2016-04-11 09:43:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874153002/1
4 years, 8 months ago (2016-04-11 16:29:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-11 18:19:48 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 18:21:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcbabe31b76d0b8e783ceeb319d7e2fa116889c7
Cr-Commit-Position: refs/heads/master@{#386413}

Powered by Google App Engine
This is Rietveld 408576698