Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 187413004: Fixed the Memcheck:Uninitialized warning in WebRtcLocalAudioTrackAdapterTest_AddAndRemoveSink (Closed)

Created:
6 years, 9 months ago by no longer working on chromium
Modified:
6 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, fischman+watch_chromium.org, glider+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, wjia+watch_chromium.org, bruening+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fixed the Memcheck:Uninitialized warning in WebRtcLocalAudioTrackAdapterTest_AddAndRemoveSink BUG=349153 TEST=bots R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255305

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
no longer working on chromium
oshima, PTAL. Thanks, SX
6 years, 9 months ago (2014-03-05 18:09:03 UTC) #1
oshima
lgtm
6 years, 9 months ago (2014-03-05 18:17:18 UTC) #2
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-05 18:56:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/187413004/1
6 years, 9 months ago (2014-03-05 18:57:14 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 19:55:35 UTC) #5
commit-bot: I haz the power
Retried try job too often on win for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number=155947
6 years, 9 months ago (2014-03-05 19:55:37 UTC) #6
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 9 months ago (2014-03-05 21:51:39 UTC) #7
no longer working on chromium
The CQ bit was unchecked by xians@chromium.org
6 years, 9 months ago (2014-03-05 21:51:46 UTC) #8
no longer working on chromium
6 years, 9 months ago (2014-03-06 10:50:24 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 manually as r255305 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698