Infer generic method invocation type.

Infer generic method invocation type.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/569928272bb3d9333213ea2716fb4ca5ee32223d

[Paul Berry, 2016-04-09 12:04:29]

lgtm

https://codereview.chromium.org/1874123002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/1874123002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:3266:
rawMethodType.typeFormals.isNotEmpty &&
This means we won't handle non-generic cases.  Suggestion: change to:

if (rawMethodType is FunctionType) {
  if (rawMethodType.typeFormals.isNotEmpty && ts is StrongTypeSystemImpl) {
    ...
  } else {
    return rawMethodType.returnType;
  }
}

(fine to do this in a follow-up CL if you want)

[scheglov, 2016-04-10 01:29:22]

https://codereview.chromium.org/1874123002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/1874123002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:3266:
rawMethodType.typeFormals.isNotEmpty &&
On 2016/04/09 12:04:29, Paul Berry wrote:
> This means we won't handle non-generic cases.  Suggestion: change to:
> 
> if (rawMethodType is FunctionType) {
>   if (rawMethodType.typeFormals.isNotEmpty && ts is StrongTypeSystemImpl) {
>     ...
>   } else {
>     return rawMethodType.returnType;
>   }
> }
> 
> (fine to do this in a follow-up CL if you want)

Thank you, fixed.

[scheglov, 2016-04-10 01:29:43]

Description was changed from

==========
Infer generic method invocation type.

R=paulberry@google.com
BUG=
==========

to

==========
Infer generic method invocation type.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/569928272bb3d9333213ea2716fb4ca5ee32223d
==========

[scheglov, 2016-04-10 01:29:45]

Committed patchset #2 (id:20001) manually as
569928272bb3d9333213ea2716fb4ca5ee32223d (presubmit successful).