chrome/browser/extensions/api/app_window/app_window_apitest.cc - Issue 18741006: [GTK] Report isMinimized and correctly restore app windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_apitest.cc

Issue 18741006: [GTK] Report isMinimized and correctly restore app windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Enable PlatformAppBrowserTest.WindowsApiProperties on GTK. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/app_window/app_window_apitest.cc

diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc

index 31eeaf71c778d33cc7920244c1a08fc4185b4a8c..5386e88767cb1a09ec23208e78734b81d63ae18c 100644

--- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc

+++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc

@@ -123,12 +123,10 @@ IN_PROC_BROWSER_TEST_F(ExperimentalPlatformAppBrowserTest, WindowsApiSetIcon) {

EXPECT_EQ(1, test_observer->icon_updates());

}

-// TODO(asargent) - Figure out what to do about the fact that minimize events

-// don't work under ubuntu unity.

-// (crbug.com/162794 and https://bugs.launchpad.net/unity/+bug/998073).

// TODO(linux_aura) http://crbug.com/163931

// Flaky on Mac, http://crbug.com/232330

-#if defined(TOOLKIT_VIEWS) && !(defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA))

+#if (defined(TOOLKIT_VIEWS) || defined(TOOLKIT_GTK)) && \

+ !(defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA))

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiProperties) {

EXPECT_TRUE(

« no previous file with comments | « no previous file | chrome/browser/ui/gtk/extensions/native_app_window_gtk.h » ('j') | chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc » ('J')