Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 1874043002: Reland of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. (Closed)

Created:
4 years, 8 months ago by mfomitchev
Modified:
4 years, 8 months ago
Reviewers:
beaudoin, xiyuan, sky, Matt Giuca
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@mus_chrome_delegates_app_list_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. (patchset #1 id:1 of https://codereview.chromium.org/1872033002/ ) Reason for revert: Relanding - this wasn't the CL that was causing the problem Original issue's description: > Revert of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. (patchset #8 id:160001 of https://codereview.chromium.org/1856943003/ ) > > Reason for revert: > Trying revert again now that dependent patch was reverted. > > Original issue's description: > > AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation. > > > > Part 1 of the refactoring: https://crrev.com/1830293002 > > Design doc: https://docs.google.com/document/d/1M9vqTTuprMssRXs8UIVaFjQUq3lUxSzwrWoPjPvca6Q/edit?ts=56d0e9f0#heading=h.b2znwtuxd2x2 > > > > This CL adds ash::AppListShowerDelegate, which is the Ash implementation of > > app_list::AppListShowerDelegate. At this point it is unused - Ash is still using > > the old ash::AppListController class to control the app list. > > > > BUG=557408 > > > > Committed: https://crrev.com/412803081c9d4f4321d267133512f45ce434fc10 > > Cr-Commit-Position: refs/heads/master@{#386123} > > TBR=sky@chromium.org,mgiuca@chromium.org,xiyuan@chromium.org,mfomitchev@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=557408 > > Committed: https://crrev.com/59dd5b86f9db22cb2e4baeb4155948bf006d3b68 > Cr-Commit-Position: refs/heads/master@{#386187} TBR=sky@chromium.org,mgiuca@chromium.org,xiyuan@chromium.org,beaudoin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true BUG=557408 Committed: https://crrev.com/6e53600def8f60d8c632fadc70d7c1939ccea347 Cr-Commit-Position: refs/heads/master@{#386251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+761 lines, -4 lines) Patch
M ash/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
A ash/app_list/app_list_shower_delegate.h View 1 chunk +102 lines, -0 lines 0 comments Download
A ash/app_list/app_list_shower_delegate.cc View 1 chunk +357 lines, -0 lines 0 comments Download
A ash/app_list/app_list_shower_delegate_factory.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ash/app_list/app_list_shower_delegate_factory.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A ash/app_list/app_list_shower_delegate_unittest.cc View 1 chunk +196 lines, -0 lines 0 comments Download
A ash/app_list/app_list_view_delegate_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
M ash/ash.gyp View 6 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mfomitchev
Created Reland of AppListController refactoring part 2: Ash's AppListShowerDelegate imlementation.
4 years, 8 months ago (2016-04-08 23:19:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874043002/1
4 years, 8 months ago (2016-04-08 23:19:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1874043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1874043002/1
4 years, 8 months ago (2016-04-08 23:20:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-08 23:57:09 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 23:58:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e53600def8f60d8c632fadc70d7c1939ccea347
Cr-Commit-Position: refs/heads/master@{#386251}

Powered by Google App Engine
This is Rietveld 408576698