Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1873963002: S390: [simulator] Initial 2-level jump table implementation (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [simulator] Initial 2-level jump table implementation The old switch-case instruction decode implementation results in a sparse table, which is not resolved by a fast jump table routing. Therefore, it is really slow in instruction decoding phase. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/4b2b34f1186f575e2ba21aa8a87762cc00d4863b Cr-Commit-Position: refs/heads/master@{#35589}

Patch Set 1 #

Patch Set 2 : Add a new line between functions #

Patch Set 3 : use original impl as base and migrate one bit a time and implement some instructions #

Patch Set 4 : rebased on master and implement a set of instr, 20% faster in zlib #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3270 lines, -8 lines) Patch
M src/s390/simulator-s390.h View 1 2 3 1 chunk +736 lines, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 2 3 6 chunks +2534 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-08 20:50:40 UTC) #1
JoranSiu
Spoke with @john.yan. We'd like to implement the EVALUATE_XX functions for the top ~10 opcodes ...
4 years, 8 months ago (2016-04-12 21:28:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873963002/60001
4 years, 8 months ago (2016-04-18 14:38:00 UTC) #4
JoranSiu
lgtm
4 years, 8 months ago (2016-04-18 14:42:36 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 14:58:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1873963002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1873963002/60001
4 years, 8 months ago (2016-04-18 16:12:02 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-18 16:14:18 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 16:15:13 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4b2b34f1186f575e2ba21aa8a87762cc00d4863b
Cr-Commit-Position: refs/heads/master@{#35589}

Powered by Google App Engine
This is Rietveld 408576698