tools/dom/scripts/systemnative.py - Issue 1873933002: Fix handling of cross-origin windows in dartium and better align general handling of different fram…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 1873933002: Fix handling of cross-origin windows in dartium and better align general handling of different fram… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/html/html_common/conversions_dartium.dart ('K') | « tools/dom/scripts/generate_blink_file.py ('k') | tools/dom/src/native_DOMImplementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index 6d0c94d78c9b500bb71e80ea76f63fa9eb147607..1f5a030fc6a581a4e7d0be8b5653a33e8b038bf0 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -116,7 +116,7 @@ class DartiumBackend(HtmlDartGenerator):

if idl_type == 'Promise':

return _promise_to_future

if conversion:

- if conversion.function_name in ('_convertNativeToDart_Window', '_convertNativeToDart_EventTarget', 'convertNativeToDart_DateTime', 'convertNativeToDart_ImageData'):

+ if conversion.function_name in ('convertNativeToDart_DateTime', 'convertNativeToDart_ImageData'):

return None

return conversion

« sdk/lib/html/html_common/conversions_dartium.dart ('K') | « tools/dom/scripts/generate_blink_file.py ('k') | tools/dom/src/native_DOMImplementation.dart » ('j') | no next file with comments »