Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1873933002: Fix handling of cross-origin windows in dartium and better align general handling of different fram… (Closed)

Created:
4 years, 8 months ago by Jacob
Modified:
4 years, 8 months ago
Reviewers:
terry, Alan Knight
CC:
reviews_dartlang.org, Alan Knight
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects. BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/f382890e1a1a719ad6d6545cb50dc0b01cf2e00c

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -142 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 chunk +0 lines, -33 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 21 chunks +78 lines, -44 lines 0 comments Download
M sdk/lib/html/html_common/conversions_dartium.dart View 1 chunk +9 lines, -3 lines 2 comments Download
M tools/dom/scripts/generate_blink_file.py View 1 chunk +0 lines, -33 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 3 chunks +28 lines, -23 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 2 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Jacob
4 years, 8 months ago (2016-04-08 19:59:17 UTC) #2
Jacob
Terry can you take a look?
4 years, 8 months ago (2016-04-12 00:31:34 UTC) #5
Jacob
Terry can you take a look?
4 years, 8 months ago (2016-04-12 00:31:34 UTC) #6
Alan Knight
https://codereview.chromium.org/1873933002/diff/20001/sdk/lib/html/html_common/conversions_dartium.dart File sdk/lib/html/html_common/conversions_dartium.dart (right): https://codereview.chromium.org/1873933002/diff/20001/sdk/lib/html/html_common/conversions_dartium.dart#newcode272 sdk/lib/html/html_common/conversions_dartium.dart:272: if (js.JsNative.hasProperty(e, "postMessage")) { Is this safe? There are ...
4 years, 8 months ago (2016-04-12 17:05:58 UTC) #8
Jacob
https://codereview.chromium.org/1873933002/diff/20001/sdk/lib/html/html_common/conversions_dartium.dart File sdk/lib/html/html_common/conversions_dartium.dart (right): https://codereview.chromium.org/1873933002/diff/20001/sdk/lib/html/html_common/conversions_dartium.dart#newcode272 sdk/lib/html/html_common/conversions_dartium.dart:272: if (js.JsNative.hasProperty(e, "postMessage")) { On 2016/04/12 17:05:58, Alan Knight ...
4 years, 8 months ago (2016-04-12 17:08:51 UTC) #9
Alan Knight
:-) LGTM
4 years, 8 months ago (2016-04-12 17:11:44 UTC) #10
Jacob
4 years, 8 months ago (2016-04-12 17:23:38 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f382890e1a1a719ad6d6545cb50dc0b01cf2e00c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698