Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: build/common.gypi

Issue 187393005: Make it possible to read CLD data from a file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase onto the CLD2 deps roll change, update readme Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 353d2762ce5ed0d36f1816860cb0240b3b2542d3..ecb3d6ae2bdc7be2a5a7e2bc03d95e9792fb7c09 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -421,6 +421,11 @@
# 2: Use only CLD2.
'cld_version%': 2,
+ # Set the way CLD is compiled
+ # 0: static, language scoring tables compiled into the binary
+ # 1: dynamic, language scoring tables live in a data file that must be loaded at runtime
+ 'cld_dynamic%': 1,
+
# Enable spell checker.
'enable_spellcheck%': 1,
@@ -614,7 +619,12 @@
'enable_automation%': 0,
'enable_extensions%': 0,
'enable_google_now%': 0,
- 'cld_version%': 1,
+ # 'cld_version%': 1,
jochen (gone - plz use gerrit) 2014/03/12 13:08:27 what's this comment supposed to tell me?
Andrew Hayden (chromium.org) 2014/03/13 16:39:48 I'll take this out. It's just there for me to conv
+ # to switch to dynamic CLD2:
+ # 'cld_version%': 2,
+ # 'cld_dynamic%': 1,
+ 'cld_version%': 2,
+ 'cld_dynamic%': 1,
'enable_spellcheck%': 0,
'enable_themes%': 0,
'remoting%': 0,
@@ -658,6 +668,7 @@
'enable_extensions%': 0,
'enable_google_now%': 0,
'cld_version%': 1,
+ 'cld_dynamic%': 0,
'enable_printing%': 0,
'enable_session_service%': 0,
'enable_themes%': 0,
@@ -967,6 +978,7 @@
'enable_spellcheck%': '<(enable_spellcheck)',
'enable_google_now%': '<(enable_google_now)',
'cld_version%': '<(cld_version)',
+ 'cld_dynamic%': '<(cld_dynamic)',
'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
'disable_ftp_support%': '<(disable_ftp_support)',
'enable_task_manager%': '<(enable_task_manager)',
@@ -2451,6 +2463,9 @@
['cld_version!=0', {
'defines': ['CLD_VERSION=<(cld_version)'],
}],
+ ['cld_dynamic!=0', {
+ 'defines': ['CLD2_DYNAMIC_MODE=1'],
+ }],
['enable_printing==1', {
'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
}],

Powered by Google App Engine
This is Rietveld 408576698