Make it possible to read CLD data from a file

build/common.gypi

Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 0de69e59df415f78d3b634adebcda66bdfc57bff..18d468dd96399b807ab6477699399dd6f98a23b4 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -425,13 +425,18 @@
       'cld_version%': 2,
 
       # For CLD2, the size of the tables that should be included in the build
-      # Only evaluated if cld_version == 2.
+      # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data tool explicitly.

[bulach, 2014/03/23 20:57:02]

nit: there's no strict limit, but from 414-418, try to keep <80cols

[Andrew Hayden (chromium.org), 2014/03/24 15:18:24]

Done.

[bulach, 2014/03/25 09:29:26]

sorry to keep pinging here, but it still looks >80 cols (and 437 too)

[bulach, 2014/03/26 19:06:45]

ping?

       # See third_party/cld_2/cld_2.gyp for more information.
       #   0: Small tables, lower accuracy
       #   1: Medium tables, medium accuracy
       #   2: Large tables, high accuracy
       'cld2_table_size%': 2,
 
+      # Set the way CLD is compiled
+      #   0: static, language scoring tables compiled into the binary
+      #   1: dynamic, language scoring tables live in a data file that must be loaded at runtime

[bulach, 2014/03/23 20:57:02]

nit: <80cols

[Andrew Hayden (chromium.org), 2014/03/24 15:18:24]

Done.

+      'cld_dynamic%': 0,
+
       # Enable spell checker.
       'enable_spellcheck%': 1,
 
@@ -629,6 +634,7 @@
           'enable_extensions%': 0,
           'enable_google_now%': 0,
           'cld_version%': 1,
+          'cld_dynamic%': 0,
           'enable_spellcheck%': 0,
           'enable_themes%': 0,
           'remoting%': 0,
@@ -679,6 +685,7 @@
           'enable_extensions%': 0,
           'enable_google_now%': 0,
           'cld_version%': 1,
+          'cld_dynamic%': 0,
           'enable_printing%': 0,
           'enable_session_service%': 0,
           'enable_themes%': 0,
@@ -995,6 +1002,7 @@
     'enable_google_now%': '<(enable_google_now)',
     'cld_version%': '<(cld_version)',
     'cld2_table_size%': '<(cld2_table_size)',
+    'cld_dynamic%': '<(cld_dynamic)',
     'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
     'disable_ftp_support%': '<(disable_ftp_support)',
     'enable_task_manager%': '<(enable_task_manager)',
@@ -2502,6 +2510,9 @@
       ['cld_version!=0', {
         'defines': ['CLD_VERSION=<(cld_version)'],
       }],
+      ['cld_dynamic!=0', {
+        'defines': ['CLD2_DYNAMIC_MODE=1'],
+      }],
       ['enable_printing==1', {
         'defines': ['ENABLE_FULL_PRINTING=1', 'ENABLE_PRINTING=1'],
       }],