Make it possible to read CLD data from a file

chrome/common/render_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included file, no traditional include guard.
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 392 matching lines @@
 // be treated as a webapp.
 IPC_MESSAGE_ROUTED1(ChromeViewMsg_RetrieveWebappInformation,
                     GURL /* expected_url */)
 
 // Asks the renderer to return information about the given meta tag.
 IPC_MESSAGE_ROUTED2(ChromeViewMsg_RetrieveMetaTagContent,
                     GURL /* expected_url */,
                     std::string /* tag_name */ )
 #endif  // defined(OS_ANDROID)
 
+// Informs the renderer process that Compact Language Detector (CLD) data is

[bulach, 2014/03/11 18:56:10]

probably best to keep close together with other translate messages?
also, the name could imply that, something like:
ChromeViewMsg_TranslateCLDDataAvailable, or something..

[Andrew Hayden (chromium.org), 2014/03/13 16:33:33]

Proximity: The ChromeViewMsg and ChromeViewHostMsg chunks seem to be divided
intentionally, which is why I've got them separated. Am I incorrect?

I prefer not to include the word Translate. Yes, it's true that Translate is
currently the only consumer of CLD data, but CLD is independent of Translate and
other features could conceivably want CLD capabilities in the future (admittedly
unlikely). If you feel strongly, let me know.

+// available and provides an IPC::PlatformFileForTransit obtained from
+// IPC::GetFileHandleForProcess(...)
+// See also: ChromeViewHostMsg_NeedCLDData
+IPC_MESSAGE_ROUTED1(ChromeViewMsg_CLDDataAvailable,
+                    IPC::PlatformFileForTransit)
+
 // chrome.principals messages ------------------------------------------------
 
 // Message sent from the renderer to the browser to get the list of browser
 // managed accounts for the given origin.
 IPC_SYNC_MESSAGE_CONTROL1_1(ChromeViewHostMsg_GetManagedAccounts,
                             GURL /* current URL */,
                             std::vector<std::string> /* managed accounts */)
 
 // Message sent from the renderer to the browser to show the browser account
 // management UI.
@@ skipping 341 matching lines @@
                      std::vector<GURL> /* search_urls */,
                      GURL /* new_tab_page_url */)
 
 // Tells listeners that a detailed message was reported to the console by
 // WebKit.
 IPC_MESSAGE_ROUTED4(ChromeViewHostMsg_DetailedConsoleMessageAdded,
                     base::string16 /* message */,
                     base::string16 /* source */,
                     extensions::StackTrace /* stack trace */,
                     int32 /* severity level */)
+
+// Informs the browser process that Compact Language Detector (CLD) data is

[bulach, 2014/03/11 18:56:10]

ditto

[Andrew Hayden (chromium.org), 2014/03/13 16:33:33]

See other response.

+// required by the originating renderer. The browser process should respond
+// with a ChromeViewMsg_CLDDataAvailable if the data is available, else it
+// should go unanswered (the renderer will ask again later)
+// See also: ChromeViewMsg_CLDDataAvailable
+IPC_MESSAGE_ROUTED0(ChromeViewHostMsg_NeedCLDData)